-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds MAM4xx Surface emissions process interface for EAMxx #2944
Adds MAM4xx Surface emissions process interface for EAMxx #2944
Conversation
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: singhbalwinder |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
SCREAM_PullRequest_Autotester_Mappy # 5798 FAILED (click to see last 100 lines of console output)
SCREAM_PullRequest_Autotester_Weaver # 6024 FAILED (click to see last 100 lines of console output)
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: singhbalwinder |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
SCREAM_PullRequest_Autotester_Mappy # 5800 FAILED (click to see last 100 lines of console output)
SCREAM_PullRequest_Autotester_Weaver # 6026 FAILED (click to see last 100 lines of console output)
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: singhbalwinder |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
SCREAM_PullRequest_Autotester_Mappy # 5803 FAILED (click to see last 100 lines of console output)
SCREAM_PullRequest_Autotester_Weaver # 6029 FAILED (click to see last 100 lines of console output)
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: singhbalwinder |
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Below is the checklist required by the PR review guidance: https://acme-climate.atlassian.net/wiki/spaces/EAMXX/pages/4128768032/Short+description+of+EAGLES+PR+review+process
Yes.
Yes, the PR summary does the job.
The new feature (when turned on) will
The aerosol and gas tracers are "prognostic" since their values are affected by transport. When this feature is turned on, the aerosol tracers (interstitial only) are affected by surface emission. Due to the idealized configuration with this feature, there is no benchmark to compare with. On the other hand, the diagnosed emission fluxes can be compared with the input emission data.
No new coupling (that directly affects meteorological fields) is added, except that aerosol concentrations will be changed by surface emission. If this feature is coupled with aci and/or aerosol optics, it will affect the aerosol effect on clouds and radiation.
The surface emission feature alone only changes aerosol and trace gas concentrations and does not directly affect meteorological fields. Also, the current tests are short idealized simulations and the impact on climate is not evaluated.
No, I think the current evaluations are sufficient. Due to the idealized configuration of the current model feature, we can only evaluate the feature impact qualitatively. It would be more meaningful to perform the aerosol mass and number budget analysis when we can run a longer simulation with more realistic aerosol fields in MAMxx/EAMxx.
The simulated surface emission fluxes and the changes in aerosol burden were assessed. The simulated spatial distributions of the emission fluxes for tracer gases (DMS & SO2) and interstitial aerosols agree with the input emission data. The simulated tracer gas & aerosol burden increases due to emissions (especially patterns) look reasonable. The feature is also tested (coupled) with other mamxx features (see link below). No obvious problem is identified. Additional diagnostics can be found here: https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.kzhang/TMP/emis/
N/A.
num_phys_constituents = 40
The process coupling between emission, dry deposition, and turbulent transport needs to be revisited when all of the aerosol processes/parameterizations have been integrated into EAMxx.
With the current implementation, MAMxx will read emission data on the model native grid (ne4pg2 or ne30pg2). For resolutions other than ne4pg2 and ne30pg2, the model will make online remapping with pre-calculated mapping weights. Supported resolutions are
RRM simulations are not supported yet. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: singhbalwinder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments in the checklist above.
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
SCREAM_PullRequest_Autotester_Mappy # 5806 FAILED (click to see last 100 lines of console output)
SCREAM_PullRequest_Autotester_Weaver # 6032 FAILED (click to see last 100 lines of console output)
|
I added timing info to the PR description. |
This PR comes with two EAMxx interfaces:
Surface emissions interface: It connects MAM4xx’s surface emissions codes to EAMxx. The surface emissions process is added as an EAMxx process (or atmosphere instance) with the ability to turn it on/off using the label
mam4_srf_online_emiss
in thenamelist_scream.xml
file.Constituent fluxes interface: This interface (called
mam4_constituent_fluxes
) is added to update prognostic variables (interstitial aerosols and gasses) using the surface emissions. Adding this as an interface provides the flexibility to invoke this process anywhere in the time loop.NOTE: The vertical or elevated emissions will be added as part of microphysics PR
Since the cmake option,
SCREAM_ENABLE_MAM
is alwaysON
, this code is always compiled with the EAMxx codebase but both the interfaces can be turned off/on using the namelist flags.Output variables
The output variable names are "constituent_fluxes" and interstitial aerosols whose emissions are read in:
so2, dms, so4_a1, num_a1, so4_a2, num_a2, pom_a4, bc_a4, num_a4
Note that the "constituent_fluxes" indices are exactly the same as EAM's state%q.
Testing
We have included three SCREAM standalone tests, two for a single process and one for multiple processes. These tests are running correctly on both CPUs and GPUs. Note that the baseline tests for these may fail because baselines are only created once the PR is merged.
srf_online_emiss
andconstituent_fluxes
processes are added as an EAMxx process with the ability to turn it on/off using the labelsmam4_srf_online_emiss
andmam4xx-constituent_fluxes
in the namelist_scream.xml file. The atmchange command to invoke these process in a CIME simulation is:./atmchange physics::atm_procs_list="mam4_constituent_fluxes,mac_aero_mic,rrtmgp,mam4_srf_online_emiss"
To run a CIME simulation, we have created a test modifier
mam4xx-srf_online_emiss_constituent_fluxes
:Where,
<machine>
is the machine name<compiler>
is the compiler to use on the machine<test id >
is a unique string test identifier<project id>
is the allocation project to chargeNew input data
We have added 10 emission files for each of the three grid resolutions:
ne2np4, ne4pg2, ne30pg2
For finer resolutions, the code will interpolate the ne30pg2 grid. All the files are on the E3SM input data server.
Figures from model analysis
The plot above shows that the burden for all the species for which we are reading emissions data is increasing with time as expected.
Standalone Test Timings (Compy):
Important notes: