Adds MAM4xx microphysics interface #3013
+4,559
−2,781
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
|
|
||
| #!/bin/sh | ||
| #------------------------------------------------------ | ||
| # MAM4xx adds additionaltracers to the simulation | ||
| # Increase number of tracers for MAM4xx simulations | ||
| #------------------------------------------------------ | ||
|
|
||
| $CIMEROOT/../components/eamxx/cime_config/testdefs/testmods_dirs/scream/mam4xx/update_eamxx_num_tracers.sh -b | ||
|
|
||
| #------------------------------------------------------ | ||
| #Update IC file and add drydep process | ||
| #------------------------------------------------------ | ||
| $CIMEROOT/../components/eamxx/scripts/atmchange initial_conditions::Filename='$DIN_LOC_ROOT/atm/scream/init/screami_mam4xx_ne4np4L72_c20240208.nc' -b | ||
| $CIMEROOT/../components/eamxx/scripts/atmchange physics::atm_procs_list="mac_aero_mic,rrtmgp,mam4_aero_microphys" -b | ||
|
|
||
|
|
||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,6 +42,7 @@ add_subdirectory(${EXTERNALS_SOURCE_DIR}/mam4xx ${CMAKE_BINARY_DIR}/externals/ma | |
| # EAMxx mam4xx-based atmospheric processes | ||
| add_library(mam | ||
| eamxx_mam_microphysics_process_interface.cpp | ||
| ${SCREAM_BASE_DIR}/src/physics/rrtmgp/shr_orb_mod_c2f.F90 | ||
|
There was a problem hiding this comment. would be good to explain why this is needed, especially that it is a F90 file. Don't we have this already in cpp? There was a problem hiding this comment. We followed RRTMGP (see here) There was a problem hiding this comment. Yeah, I don't think we converted this. |
||
| eamxx_mam_optics_process_interface.cpp | ||
| eamxx_mam_dry_deposition_process_interface.cpp | ||
| eamxx_mam_aci_process_interface.cpp | ||
|
|
@@ -54,7 +55,7 @@ target_include_directories(mam PUBLIC | |
| ${EXTERNALS_SOURCE_DIR}/haero | ||
| ${EXTERNALS_SOURCE_DIR}/mam4xx/src | ||
| ) | ||
| target_link_libraries(mam PUBLIC physics_share csm_share scream_share mam4xx haero) | ||
|
There was a problem hiding this comment. An example of something that could've been handled by another PR to make this PR more focused and leaner. There was a problem hiding this comment. Again, we followed RRTMGP here for now. |
||
|
|
||
| #if (NOT SCREAM_LIB_ONLY) | ||
| # add_subdirectory(tests) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any change you can add some doc strings for these parameters?