Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flush and close output files that are full #3032

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Flush and close output files that are full #3032

merged 8 commits into from
Oct 17, 2024

Commits on Oct 4, 2024

  1. A quick change to recreate an aborted run mid simulation

    @AaronDonahue
    AaronDonahue committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    463ffbc View commit details
    Browse the repository at this point in the history

  2. Change the name of fail option to be self-descriptive

    @AaronDonahue
    AaronDonahue committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f1b3a4b View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. If output file has reached the maximum number of steps than close it. 

    This commit addresses an issue with empty output files that should have
been flushed and closed.  If the simulation exits abnormally before a
file has been flushed then the file will be empty.

Before, we left it up to SCORPIO to decide the optimal time to flush
output.  In this commit we force a file that is full, i.e. max_snapshots
has been reached, to be flushed and closed before moving on.  This
should ensure that all full files are written before any chance of an
abnormal exit.
    @AaronDonahue
    AaronDonahue committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e871e77 View commit details
    Browse the repository at this point in the history

  2. use function snapshot_fits to check if file is full. Accomodates othe… 

    …r file storage types
    @AaronDonahue
    AaronDonahue committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f9d8bc9 View commit details
    Browse the repository at this point in the history

  3. remove a check to release file that is no longer needed

    @AaronDonahue
    AaronDonahue committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    eabd70f View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. EAMxx: remove unused param in unit tests inputs

    @bartgol
    bartgol committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    488c789 View commit details
    Browse the repository at this point in the history

  2. EAMxx: fix closure of full files for storage type!=NumSnaps

    @bartgol
    bartgol committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    c99a7d9 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. EAMxx: make comment clearer in IO header

    @bartgol
    bartgol committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    033d31e View commit details
    Browse the repository at this point in the history