Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add runtime flag for p3 ice production #3035

Merged
merged 2 commits into from
Oct 11, 2024
Merged

add runtime flag for p3 ice production #3035

merged 2 commits into from
Oct 11, 2024

Conversation

mahf708
Copy link
Contributor

@mahf708 mahf708 commented Oct 9, 2024 •
edited
Loading

Add flag to turn on ice production processes in P3 (loss processes unaffected)

passes p3_standalone_baseline_cmp in dbg on pm-gpu

[bfb]

@mahf708 mahf708 added p3 regarding p3 microphysics AT: AUTOMERGE Inform the autotester (AT) that it can merge this PR if reviewers approved, and tests pass namelist labels Oct 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/scream/pr-preview/pr-3035/
on branch gh-pages at 2024-10-10 21:26 UTC

@mahf708 mahf708 added the BFB Bit for bit label Oct 9, 2024
@mahf708 mahf708 removed the AT: AUTOMERGE Inform the autotester (AT) that it can merge this PR if reviewers approved, and tests pass label Oct 9, 2024
bartgol
bartgol previously approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@bartgol bartgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't comment on physics modeling part, but the code/ad stuff is good.

@E3SM-Autotester
Copy link
Collaborator

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

  • Build Num: 6140
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS BFB;p3;namelist
PULLREQUESTNUM 3035
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA c5251bd
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA e4b2d35
TEST_REPO_ALIAS SCREAM

Build Information

Test Name: SCREAM_PullRequest_Autotester_Mappy

  • Build Num: 5902
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS BFB;p3;namelist
PULLREQUESTNUM 3035
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA c5251bd
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA e4b2d35
TEST_REPO_ALIAS SCREAM

Using Repos:

Repo: SCREAM (E3SM-Project/scream)
  • Branch: mahf708/p3/runtime-options
  • SHA: c5251bd
  • Mode: TEST_REPO

Pull Request Author: mahf708

@E3SM-Autotester
Copy link
Collaborator

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

  • Build Num: 6140
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS BFB;p3;namelist
PULLREQUESTNUM 3035
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA c5251bd
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA e4b2d35
TEST_REPO_ALIAS SCREAM

Build Information

Test Name: SCREAM_PullRequest_Autotester_Mappy

  • Build Num: 5902
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS BFB;p3;namelist
PULLREQUESTNUM 3035
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA c5251bd
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA e4b2d35
TEST_REPO_ALIAS SCREAM

@E3SM-Autotester
Copy link
Collaborator

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@mahf708 mahf708 added AT: AUTOMERGE Inform the autotester (AT) that it can merge this PR if reviewers approved, and tests pass AT: RETEST Force the autotester (AT) to retest the PR labels Oct 10, 2024
@mahf708 mahf708 requested a review from bartgol October 10, 2024 21:27
@E3SM-Autotester
Copy link
Collaborator

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@E3SM-Autotester
Copy link
Collaborator

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

  • Build Num: 6142
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS BFB;p3;AT: RETEST;AT: AUTOMERGE;namelist
PULLREQUESTNUM 3035
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA 7edd4b7
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA e4b2d35
TEST_REPO_ALIAS SCREAM

Build Information

Test Name: SCREAM_PullRequest_Autotester_Mappy

  • Build Num: 5904
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS BFB;p3;AT: RETEST;AT: AUTOMERGE;namelist
PULLREQUESTNUM 3035
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA 7edd4b7
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA e4b2d35
TEST_REPO_ALIAS SCREAM

Using Repos:

Repo: SCREAM (E3SM-Project/scream)
  • Branch: mahf708/p3/runtime-options
  • SHA: 7edd4b7
  • Mode: TEST_REPO

Pull Request Author: mahf708

@E3SM-Autotester
Copy link
Collaborator

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

  • Build Num: 6142
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS BFB;p3;AT: RETEST;AT: AUTOMERGE;namelist
PULLREQUESTNUM 3035
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA 7edd4b7
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA e4b2d35
TEST_REPO_ALIAS SCREAM

Build Information

Test Name: SCREAM_PullRequest_Autotester_Mappy

  • Build Num: 5904
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS BFB;p3;AT: RETEST;AT: AUTOMERGE;namelist
PULLREQUESTNUM 3035
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA 7edd4b7
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA e4b2d35
TEST_REPO_ALIAS SCREAM

@E3SM-Autotester E3SM-Autotester removed the AT: RETEST Force the autotester (AT) to retest the PR label Oct 11, 2024
@E3SM-Autotester E3SM-Autotester merged commit 73446d8 into master Oct 11, 2024
6 checks passed
@E3SM-Autotester E3SM-Autotester removed the AT: AUTOMERGE Inform the autotester (AT) that it can merge this PR if reviewers approved, and tests pass label Oct 11, 2024
@E3SM-Autotester E3SM-Autotester deleted the mahf708/p3/runtime-options branch October 11, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassanbeydoun hassanbeydoun hassanbeydoun approved these changes

@AaronDonahue AaronDonahue Awaiting requested review from AaronDonahue

@bartgol bartgol Awaiting requested review from bartgol

Assignees
No one assigned
Labels
BFB Bit for bit namelist p3 regarding p3 microphysics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mahf708 @E3SM-Autotester @bartgol @hassanbeydoun