Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Kokkos Dev Documentation #3046

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

tcclevenger
Copy link
Contributor

No description provided.

Copy link

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/scream/pr-preview/pr-3046/
on branch gh-pages at 2024-10-18 05:34 UTC

@E3SM-Autotester
Copy link
Collaborator

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

  • Build Num: -1
  • Status: SKIPPED

Jenkins Parameters

Parameter Name Value

Build Information

Test Name: SCREAM_PullRequest_Autotester_Mappy

  • Build Num: -1
  • Status: SKIPPED

Jenkins Parameters

Parameter Name Value

Using Repos:

Repo: SCREAM (E3SM-Project/scream)
  • Branch: tcclevenger/doc_dev_kokkos_ekat
  • SHA: 5650700
  • Mode: TEST_REPO

Pull Request Author: tcclevenger

@E3SM-Autotester
Copy link
Collaborator

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

  • Build Num: -1
  • Status: SKIPPED

Jenkins Parameters

Parameter Name Value

Build Information

Test Name: SCREAM_PullRequest_Autotester_Mappy

  • Build Num: -1
  • Status: SKIPPED

Jenkins Parameters

Parameter Name Value

@E3SM-Autotester
Copy link
Collaborator

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@E3SM-Autotester
Copy link
Collaborator

All Jobs Finished; status = PASSED, target_sha=890d5d7778f8882628c67cf05f406bd859c0c0b4, However Inspection must be performed before merge can occur...

Copy link
Contributor

@bartgol bartgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! When you get around to expand the EKAT part, I don't think we need a subsection for all those topics. I think we can group topics, and maybe spend a subsection for one or two that developers may interact with, and that may have some gotchas. For instance, I would spend a section on packs (which are used everywhere), and workspace manager (which has a few gotchas).

@E3SM-Autotester
Copy link
Collaborator

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@bartgol bartgol merged commit 624e53c into master Oct 18, 2024
4 checks passed
@bartgol bartgol deleted the tcclevenger/doc_dev_kokkos_ekat branch October 18, 2024 14:15
@tcclevenger
Copy link
Contributor Author

Looks good! When you get around to expand the EKAT part, I don't think we need a subsection for all those topics. I think we can group topics, and maybe spend a subsection for one or two that developers may interact with, and that may have some gotchas. For instance, I would spend a section on packs (which are used everywhere), and workspace manager (which has a few gotchas).

Sounds good, I'll try to get something this morning. And yeah, WSM, Packs for sure, and then I think the Kokkos typedefs/execution policies I think I should point to, but thats not much info to put down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants