Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search to return the confidence #54

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

dglemos
Copy link
Collaborator

@dglemos dglemos commented Oct 16, 2024

Ticket: G2P-311

Output format for search type gene:

{
            "id": "G2P02001",
            "gene": "CDH1",
            "genotype": "monoallelic_autosomal",
            "disease": "Blepharo-cheiro-dontic syndrome",
            "mechanism": "undetermined",
            "panel": [
                "DD"
            ],
            "confidence": "definitive"
}

Output format for search type draft:

{
            "id": "G2P03716",
            "gene": "CDH1",
            "date_created": "2024-10-10T15:20:33.620010Z",
            "date_last_updated": "2024-10-10T15:20:33.620010Z",
            "curator_first": "Diana",
            "curator_last_name": "Lemos",
            "genotype": "biallelic_PAR",
            "disease_name": "test name",
            "panels": [
                "Demo"
            ],
            "confidence": "disputed",
            "curator_email": "[email protected]"
}

Note: the failing tests are not related to this update.

@olaaustine
Copy link
Collaborator

Since we are keeping the search draft to be the same as the regular search, should we also add confidence to the return for search.

Copy link
Collaborator

@seeta-ramaraju seeta-ramaraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeta-ramaraju seeta-ramaraju merged commit 93e641c into EBI-G2P:main Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants