Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with BioSamples inferred disease #360

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

CinciaT
Copy link
Contributor

@CinciaT CinciaT commented Dec 18, 2020

No description provided.

@CinciaT CinciaT requested a review from FuqiX December 18, 2020 09:30
Copy link
Contributor

@FuqiX FuqiX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Cincia.

The updates are really detailed and nicely formatted. Thanks! I have some questions related to the new section. Could you please elaborate in the documentation?

  1. why biosamples want to curate disease. (A request from Phenopacket?). why not other attributes.
  2. which samples does the new curation rules apply to. all samples, all disease samples , or samples from a specific project?
  3. what are the "manual rules" you gave a very nice example. can you please summarize the rules
  4. I think a very nice feature of your curation is that, BSD don't overwrite the original attributes, but generating a new attribute alongside the attributes. Is it possible to highlight this one.

In the example you provided, the basic curation rules are silimar to the previous ones "text curation", "ontology anotations" I am thinking will it better to list "Automated curation, add Biosamples inferred disease" as "curation projects: add Biosamples inferred disease" This way the new structure will be like:

  • automated curation
  • curation projects
  • manual curation
    There might be other ways to do this.

@FuqiX FuqiX requested a review from theisuru December 18, 2020 11:31
@CinciaT CinciaT changed the title Update with BSD inferred disease Update with BioSamples inferred disease Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants