Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

検索結果0件のページと在庫切れのページを noindex とする #5019

Merged
merged 10 commits into from
Jul 7, 2021

Conversation

matsuoshi
Copy link
Contributor

@matsuoshi matsuoshi commented Apr 20, 2021

4.1向けのプルリクエストです
#4987 から継続して作業しています

概要(Overview・Refs Issue)

以下の条件のページについて、SEO観点から meta noindex タグを付加する

  • 検索結果 0件
  • 在庫切れ商品

関連issue

#5014
#4807 (comment)

方針(Policy)

4.1用の meta.twig テンプレート内にて、条件により meta index 付加する/しないを判定

実装に関する補足(Appendix)

テスト(Test)

noindex が付加される場合/されない場合について、webテストを追加しています

相談(Discussion)

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

@matsuoshi matsuoshi force-pushed the feature/seo-noindex branch from ec810f1 to 6ebb726 Compare April 20, 2021 03:03
@matsuoshi matsuoshi changed the base branch from 4.1-beta2 to 4.1-feature April 20, 2021 03:04
@matsuoshi matsuoshi changed the title [WIP]検索結果0件のページと在庫切れのページを noindex とする 検索結果0件のページと在庫切れのページを noindex とする Apr 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2021

Codecov Report

Merging #5019 (cd2699e) into 4.1 (8c3ae69) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                4.1    #5019   +/-   ##
=========================================
  Coverage     75.96%   75.97%           
  Complexity     5946     5946           
=========================================
  Files           449      449           
  Lines         20922    20922           
=========================================
+ Hits          15893    15895    +2     
+ Misses         5029     5027    -2     
Flag Coverage Δ
tests 75.97% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Eccube/Controller/ProductController.php 93.04% <0.00%> (+0.53%) ⬆️
src/Eccube/Repository/ProductRepository.php 97.57% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c3ae69...cd2699e. Read the comment docs.

@matsuoshi matsuoshi force-pushed the feature/seo-noindex branch from 6ebb726 to 032efef Compare July 5, 2021 00:56
@matsuoshi matsuoshi mentioned this pull request Jul 6, 2021
13 tasks
@chihiro-adachi chihiro-adachi changed the base branch from 4.1-feature to 4.1 July 6, 2021 07:54
@chihiro-adachi chihiro-adachi added the enhancement 機能追加 label Jul 7, 2021
@chihiro-adachi chihiro-adachi added this to the 4.1 milestone Jul 7, 2021
@chihiro-adachi chihiro-adachi merged commit e5a7b62 into EC-CUBE:4.1 Jul 7, 2021
@chihiro-adachi
Copy link
Contributor

@matsuoshi
#4987 の修正も確認できましたので、マージしました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected:template フロントテンプレートの変更 enhancement 機能追加
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants