Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony/EventDispatcher #54

Merged
merged 7 commits into from
Jul 5, 2023

Conversation

kiy0taka
Copy link
Contributor

概要(Overview・Refs Issue)

#40

方針(Policy)

実装に関する補足(Appendix)

テスト(Test)

相談(Discussion)

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更はありません
  • フックポイントの呼び出しタイミングの変更はありません
  • フックポイントのパラメータの削除・データ型の変更はありません
  • twigファイルに渡しているパラメータの削除・データ型の変更はありません
  • Serviceクラスの公開関数の、引数の削除・データ型の変更はありません
  • 入出力ファイル(CSVなど)のフォーマット変更はありません

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか
    • 権限を超えた操作が可能にならないか
    • 不要なファイルアップロードがないか
    • 外部へ公開されるファイルや機能の追加ではないか
    • テンプレートでのエスケープ漏れがないか

@kiy0taka kiy0taka force-pushed the next/dev/event-dispatcher branch from d9594b6 to dbb8fae Compare June 29, 2023 08:28
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Merging #54 (03a29d9) into main (c017ec3) will increase coverage by 0.00%.
The diff coverage is 68.18%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff            @@
##               main      #54   +/-   ##
=========================================
  Coverage     79.50%   79.50%           
- Complexity     7265     7276   +11     
=========================================
  Files           604      607    +3     
  Lines         28255    28272   +17     
=========================================
+ Hits          22464    22479   +15     
- Misses         5791     5793    +2     
Flag Coverage Δ
E2E 68.97% <68.18%> (+<0.01%) ⬆️
Unit 77.09% <68.18%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cube/Controller/Admin/Store/TemplateController.php 53.07% <ø> (ø)
...tion/Eccube/Controller/InstallPluginController.php 0.00% <0.00%> (ø)
src/application/Eccube/Service/MailService.php 83.98% <ø> (ø)
src/framework/Eccube/EventDispatcher/Event.php 50.00% <50.00%> (ø)
...amework/Eccube/EventDispatcher/EventDispatcher.php 66.66% <66.66%> (ø)
src/application/Eccube/Service/SystemService.php 75.00% <100.00%> (ø)
...ccube/EventDispatcher/EventDispatcherDecorator.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


namespace Eccube\EventDispatcher;

interface EventSubscriberInterface extends \Composer\EventDispatcher\EventSubscriberInterface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiy0taka
ComposerのEventSubscriberInterfaceになってます。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chihiro-adachi 修正しておきました!

@chihiro-adachi chihiro-adachi merged commit 375a9ef into EC-CUBE:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants