-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symfony/EventDispatcher #54
Symfony/EventDispatcher #54
Conversation
…EventDispatcher\EventDispatcher
d9594b6
to
dbb8fae
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #54 +/- ##
=========================================
Coverage 79.50% 79.50%
- Complexity 7265 7276 +11
=========================================
Files 604 607 +3
Lines 28255 28272 +17
=========================================
+ Hits 22464 22479 +15
- Misses 5791 5793 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
||
namespace Eccube\EventDispatcher; | ||
|
||
interface EventSubscriberInterface extends \Composer\EventDispatcher\EventSubscriberInterface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kiy0taka
ComposerのEventSubscriberInterfaceになってます。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chihiro-adachi 修正しておきました!
TerminateEvent -> Eccube\EventDispatcher\Event
概要(Overview・Refs Issue)
#40
方針(Policy)
実装に関する補足(Appendix)
テスト(Test)
相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目