Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve issues with different ways of specifiying netcdf output optio… #230

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

jmccreight
Copy link
Member

@jmccreight jmccreight commented Aug 10, 2023

…ns: in control.options vs model.initialize. solution is dont mix

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #230 (3ff3be3) into develop (5dcbc04) will increase coverage by 0.06%.
The diff coverage is 95.65%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop     #230      +/-   ##
===========================================
+ Coverage    79.55%   79.61%   +0.06%     
===========================================
  Files           51       51              
  Lines         6475     6491      +16     
===========================================
+ Hits          5151     5168      +17     
+ Misses        1324     1323       -1     
Files Changed Coverage Δ
pywatershed/base/model.py 94.87% <95.65%> (+0.83%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmccreight jmccreight merged commit 811c689 into EC-USGS:develop Aug 17, 2023
9 checks passed
@jmccreight jmccreight deleted the bug_netcdf_control_opts branch September 6, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selected output variable netcdf files not writing to output folder
2 participants