Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat flow dag #233

Merged
merged 128 commits into from
Jul 2, 2024
Merged

Feat flow dag #233

merged 128 commits into from
Jul 2, 2024

Conversation

jmccreight
Copy link
Member

@jmccreight jmccreight commented Aug 11, 2023

  • Closes Implement STARFIT into PRMSChannel network #176
  • Tests added
  • Performance benchmarks added
  • Performance regression benchmarks run
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst or it's sub rsts?

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Attention: Patch coverage is 74.06114% with 297 lines in your changes missing coverage. Please review.

Project coverage is 73.01%. Comparing base (55181d5) to head (8d121ea).
Report is 2 commits behind head on develop.

Current head 8d121ea differs from pull request most recent head 4ee456a

Please upload reports for the commit 4ee456a to get more accurate results.

Files Patch % Lines
pywatershed/plot/domain_plot.py 0.00% 97 Missing ⚠️
pywatershed/parameters/starfit_parameters.py 20.58% 54 Missing ⚠️
pywatershed/hydrology/starfit.py 85.57% 44 Missing ⚠️
pywatershed/hydrology/prms_channel_flow_graph.py 90.16% 30 Missing ⚠️
pywatershed/base/budget.py 63.63% 28 Missing ⚠️
pywatershed/hydrology/obsin_node.py 46.93% 26 Missing ⚠️
pywatershed/base/flow_graph.py 91.08% 14 Missing ⚠️
pywatershed/plot/__init__.py 0.00% 2 Missing ⚠️
pywatershed/base/conservative_process.py 90.90% 1 Missing ⚠️
pywatershed/base/process.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #233      +/-   ##
===========================================
+ Coverage    72.34%   73.01%   +0.66%     
===========================================
  Files           53       59       +6     
  Lines         6842     7938    +1096     
===========================================
+ Hits          4950     5796     +846     
- Misses        1892     2142     +250     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmccreight jmccreight merged commit 8c2682b into EC-USGS:develop Jul 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement STARFIT into PRMSChannel network
2 participants