Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tdey/intel xpu #122

Open
wants to merge 1 commit into
base: intel_xpu
Choose a base branch
from
Open

Tdey/intel xpu #122

wants to merge 1 commit into from

Conversation

newtdms
Copy link

@newtdms newtdms commented Aug 18, 2023

Added callbacks to measure performance throughput more precisely. By default, it shows the throughput for each epoch.
Updated the optimizer API for keras==2.12 and keras==3.13 version

…default, it shows the throughput for each epoch.

Updated the optimizer API for keras==2.12 and keras==3.13 version
@newtdms newtdms requested a review from hyoo August 18, 2023 19:15
@newtdms newtdms changed the base branch from master to intel_xpu November 27, 2023 23:01
@venkat-1
Copy link

LGTM

@jmohdyusof
Copy link
Contributor

Is there anything in the performance callback that is Intel-specific? I may lift it into candle_lib unless there are objections (and after testing)

@rajeeja
Copy link
Contributor

rajeeja commented Dec 13, 2023

Is there anything in the performance callback that is Intel-specific? I may lift it into candle_lib unless there are objections (and after testing)

tested a few and it seems to work on my local machine.

@jmohdyusof
Copy link
Contributor

OK. This branch is still using /common instead of candle_lib so I will not try to merge it. We should try to fix the offload syntax so that xpu, gpu etc are supported in the same code

@newtdms
Copy link
Author

newtdms commented Dec 13, 2023

LGTM

Thanks Venkat. I added you as a reviewer. I need approval to merge the patch.

@newtdms
Copy link
Author

newtdms commented Dec 13, 2023

Is there anything in the performance callback that is Intel-specific? I may lift it into candle_lib unless there are objections (and after testing)

No, nothing Intel-specific. This is more precise way for measuring performance. The same callbacks work on A100 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants