Doxygen CI: Warnings as Error

[ax3l]

Make sure that no Doxygen warnings get in, as we do in other CI runs already.

Depends on AMReX-Codes/amrex#3061

[dpgrote]

Thanks!

[EZoni]

Found this old PR and just merged development in to see if we can finalize it easily.

[EZoni]

FYI, still struggling to "fix" this:

/home/runner/work/WarpX/WarpX/Source/Utils/ParticleUtils.H:36: error: no matching file member found for 
amrex::DenseBins< ParticleTileDataType > ParticleUtils::findParticlesInEachCell(int lev, const amrex::MFIter &mfi, WarpXParticleContainer::ParticleTileType &ptile)
Possible candidates:
 'amrex::DenseBins< ParticleTileDataType > findParticlesInEachCell(int lev, const amrex::MFIter &mfi, ParticleTileType &ptile)' at line 40 of file /home/runner/work/WarpX/WarpX/Source/Utils/ParticleUtils.cpp
 (warning treated as error, aborting now)

[EZoni]

I'd be happy to finalize this, unfortunately when I tried in December I ran into the weird "error" (which seems to me like a false positive) described in #3560 (comment) above, and I could not figure out how to fix it. We can see how it goes now, after the latest rebase.

[ax3l]

We could try to check if the .H and .cpp use the same namespace::prefixes:: for their types in arguments and that the include of the .H file is in the respective .cpp file. I see something similar in the implicit solver.

[EZoni]

Since I saw some momentum on the Doxygen side of things in AMReX, ImpactX, etc., I merged development again here to see where we stand.

[EZoni]

Despite trying many manual fixes, I still see errors like the following one, which I have not managed to fix yet. The two signatures seem identical, except for the namespace prefix ParticleUtils::, which I thought would be automatically propagated, given that everything seems to be included correctly in the source code:

/home/runner/work/WarpX/WarpX/Source/Utils/ParticleUtils.H:36: error: no matching file member found for 
amrex::DenseBins< ParticleTileDataType > ParticleUtils::findParticlesInEachCell(int lev, const amrex::MFIter &mfi, WarpXParticleContainer::ParticleTileType &ptile)
Possible candidates:
 'amrex::DenseBins< ParticleTileDataType > findParticlesInEachCell(int lev, const amrex::MFIter &mfi, WarpXParticleContainer::ParticleTileType &ptile)' at line 40 of file /home/runner/work/WarpX/WarpX/Source/Utils/ParticleUtils.cpp
 (warning treated as error, aborting now)

@AlexanderSinn @WeiqunZhang

Is this similar to the issue you fixed in AMReX recently or was it something different?

[AlexanderSinn]

Its a different issue. Maybe it would help to remove the using declaration of ParticleTileType and ParticleTileDataType from the cpp file, since they are already in the header.

[EZoni]

Since the issue persists, I was looking more into this and also noted that I don't seem to see a problem when I run .github/workflows/source/doxygen locally. I see that my Doxygen version is 1.9.8, while the version used in our GitHub Actions workflow is 1.9.1.