[WIP] Split Particle Container Init Logic #5015
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -45,9 +45,9 @@ | |||
|
|
|||
| using namespace amrex::literals; | |||
|
|
|||
| PlasmaInjector::PlasmaInjector (int ispecies, const std::string& name, | |||
| PlasmaInjector::PlasmaInjector (const std::string& name, | |||
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
|
I am back from vacation working on this again now. |
ax3l
force-pushed
the
topic-pc-init-fields
branch
3 times, most recently
from
d9fd104 to
dc71c1c
Compare
ax3l
force-pushed
the
topic-pc-init-fields
branch
3 times, most recently
from
ba678b7 to
5a6070e
Compare
ax3l
force-pushed
the
topic-pc-init-fields
branch
from
5a6070e to
ad89dc8
Compare
ax3l
force-pushed
the
topic-pc-init-fields
branch
from
ad89dc8 to
54100a3
Compare
|
Back from parental leave (part 1) and working on this again. |
ax3l
force-pushed
the
topic-pc-init-fields
branch
from
54100a3 to
2ea9c80
Compare
| WarpX::PrintDtDxDyDz(); | ||
| PostRestart(); | ||
| reduced_diags->InitData(); | ||
| // InitDiagnostics(); |
Check notice
Code scanning / CodeQL
Commented-out code Note
ax3l
changed the title
ax3l
force-pushed
the
topic-pc-init-fields
branch
from
2ea9c80 to
07d6878
Compare
ax3l
force-pushed
the
topic-pc-init-fields
branch
from
07d6878 to
cfc39f4
Compare
| @@ -19,6 +19,7 @@ | |||
| h_policies.resize(names.size()); | |||
| for (const auto& kv : names) | |||
| { | |||
| //amrex::Print() << "getPolicies: " << kv.first << " " << kv.second << std::endl; | |||
Check notice
Code scanning / CodeQL
Commented-out code Note
ax3l
force-pushed
the
topic-pc-init-fields
branch
from
76deb19 to
2f18c0a
Compare
Minimize the logic done in the particle container constructor. Init data in `InitData()`. This is needed to have access to field data during particle init, e.g., to load particles from density files.
- special treatment of `pc_tmp` - `ispecies` is unused
QED logic init requires initialized particle species.
In IDEs, we want to attach debuggers to CTest runs. This needs an option to disable signal handling from AMReX to work.
ax3l
force-pushed
the
topic-pc-init-fields
branch
from
2f18c0a to
4dfcf56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the particle init is done very early in WarpX, which complicates new logic for when we want to query large, distributed fields to initialize particles from field values (external files of density and temperature maps, etc.).
This PR minimizes the logic done in the particle container constructor. We now init data explicitly in
InitData()calls. This makes it easier to create particle container variables and meshes and then initialize particles based on initialized meshes at a later point in the logic.Isolated from #4754 for separate testing & merging.