Fix restart for implicit simulations #5489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a bonus, the parallel communication is also turned off
|
Hi @JustinRayAngus - just checking, did you get a chance to verify that this fixes the issue for you? |
EZoni
added
bug
|
Shall we merge |
I can do the merge of development. I've checked the changes in this PR and it works. |
EZoni
approved these changes
Jan 17, 2025
dpgrote
approved these changes
Jan 17, 2025
ax3l
reviewed
Jan 17, 2025
|
|
||
| pc->Checkpoint(dir, part_diag.getSpeciesName(), true, | ||
| pc->Checkpoint(dir, part_diag.getSpeciesName(), |
There was a problem hiding this comment.
@JustinRayAngus is experiencing a build issue from this call right now. @dpgrote is taking a look.
ax3l
added
component: checkpoint/restart
JustinRayAngus
pushed a commit
that referenced
this pull request
Feb 3, 2025
This adds a reduced diagnostic that calculates the Poynting flux on the surfaces of the domain, providing the power flow into and out of the domain. This also includes the time integrated data. When using the implicit evolve scheme, to get the energy accounting correct, the flux needs to be calculated at the mid step. For this reason, the `ComputeDiagsMidStep` was added which is called directly at the appropriate times. Because of the time integration, there are two main differences of this reduced diagnostic compared to the others. The first is that it is calculated every time step in order to get the full resolution in time. The intervals parameter still controls how often the diagnostic data is written out. The second is that a facility is added to write out the values of the time integration to a file when a checkpoint is made, so on a restart the integration can continue with the previous values. The facility was written in a general way so that other reduced diagnostics can also do this. The CI test using the implicit solver is dependent on PR #5498 and PR #5489. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5482.
Also, with this PR the temporary implicit particle attributes are not written to the checkpoint file, and also are not communicated when doing a redistribute of the particles. Note that this requires AMReX PR #4264.
A CI test of this restart is included in PR #5475.