Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: More Developer Packages #5568

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jan 16, 2025

Add missing developer packages to our conda developer environment.

X-ref: ECP-WarpX/impactx#801

Add missing developer packages to our conda developer environment.
@ax3l ax3l added bug Something isn't working component: documentation Docs, readme and manual install bug: affects latest release Bug also exists in latest release version component: Python Python layer labels Jan 16, 2025
@EZoni EZoni self-assigned this Jan 16, 2025
@EZoni EZoni enabled auto-merge (squash) January 16, 2025 22:09
@EZoni EZoni disabled auto-merge January 16, 2025 23:39
@EZoni
Copy link
Member

EZoni commented Jan 16, 2025

@ax3l

FYI, I had enabled auto-merge here, but I forgot that GitHub thinks that required workflows that are skipped (like here, since we change only documentation files) are pending instead of skipped, so I cannot merge PRs where we skip required workflows (i.e., all documentation PRs). I think only maintainers with higher admin access can force the merge, like @ax3l or @RemiLehe.

We saw and looked a bit into this in the last couple of months, see for instance #5469. This is a known issue (or feature?) on the GitHub end, see their notes at https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/skipping-workflow-runs.

@EZoni EZoni removed their assignment Jan 16, 2025
@ax3l
Copy link
Member Author

ax3l commented Jan 21, 2025

That is right. The workflow to mark a workflow as "skipped" as you planned will not work then. You can though early return and mark as success to speed up CI.

@ax3l ax3l merged commit d07326b into ECP-WarpX:development Jan 21, 2025
8 checks passed
@ax3l ax3l deleted the doc-more-conda-env-packages branch January 21, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: documentation Docs, readme and manual component: Python Python layer install
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants