Only allocate edge_lengths and face_areas when using the ECT solver
#5593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
commented
Jan 22, 2025
| @@ -43,7 +43,7 @@ | |||
|
|
|||
| flag_correct_div = False | |||
|
|
|||
| solver = picmi.ElectromagneticSolver(grid=grid, method="Yee", cfl=1.0) | |||
| solver = picmi.ElectromagneticSolver(grid=grid, method="ECT", cfl=1.0) | |||
There was a problem hiding this comment.
This test fails when using the "Yee" solver, because the MultiFab that are accessed with PICMI do not exist ; not sure how we want to handle this type of error in general.
There was a problem hiding this comment.
One way to handle this would be to create a python accessible function that would create those multifabs if they don't exist and return them. But that would still require this test to change since in that case Python would have to take ownership of the multifabs themselves, not just wrappers for them. I think it is okay to not support that at this time. If it turns out there are users that rely on those multifabs we can fix it when they come forward. How does that sound?
RemiLehe
commented
Jan 22, 2025
Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceSolver.H
Outdated
Show resolved
Hide resolved
RemiLehe
commented
Jan 22, 2025
Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceSolver.H
Outdated
Show resolved
Hide resolved
roelof-groenewald
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #5558, the MultiFab
edge_lengthsandface_areasare not used anymore, expect for the ECT solver. Thus, only allocateing them when using the ECT solver saves a considerable amount of memory.