[WIP] Refactor user interface of JRhom algorithm (previously multi-J) #5647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement what was discussed during the hackathon and summarized in #5229 (comment).
If accepted, this PR should replace #5229, which addressed only renaming and has many merge conflicts.
The previous input parameters
warpx.do_multi_J
warpx.do_multi_J_n_depositions
psatd.rho_in_time
psatd.J_in_time
are replaced with the one new input parameter
psatd.JRhom
, a string such asCC1
,CL2
, etc., which encodesThis is aligned with the conventions used in the paper where we published the algorithm.
To-do:
psatd.JRhom