Cropping of particles at boundaries for deposition for charge conservation #5649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only in Villasenor and Buneman current deposition in this commit
|
The cropping should not be applied at PMC (symmetry) boundaries. Only at physical boundaries like conductors and insulators. |
Comment on lines
+490
to
+494
| || field_boundary_lo[idim] == FieldBoundaryType::PMC)); | ||
| is_absorbing[idim][1] = (tilebox.bigEnd(idim) >= domain_box.bigEnd(idim) && | ||
| (field_boundary_hi[idim] == FieldBoundaryType::PEC | ||
| || field_boundary_hi[idim] == FieldBoundaryType::PMC)); | ||
| } |
There was a problem hiding this comment.
PMC ==> PECInsulator
| if (check[0] && x < xmin) { return xmin; } | ||
| if (check[1] && x > xmax) { return xmax; } | ||
| return x; | ||
| } |
There was a problem hiding this comment.
I don't think this is sufficient for D>1. You need to crop the full position vector where the particle intersects the boundary. See the truncate_boundaries() routine in picnic/src/particle_tools/MeshInterpChargeConservingF.ChF
Comment on lines
+953
to
+957
| amrex::Real const zp_np1_c = ParticleUtils::crop_at_boundary(zp_np1, xyzmin.z, xyzmax.z, is_absorbing[WARPX_ZINDEX]); | ||
| // Keep these double to avoid bug in single precision | ||
| double const z_new = (zp_np1 - xyzmin.z)*dinv.z; | ||
| double const z_new = (zp_np1_c - xyzmin.z)*dinv.z; | ||
| double const z_old = (zp_n - xyzmin.z)*dinv.z; | ||
| double const z_bar = (zp_nph - xyzmin.z)*dinv.z; | ||
| double const z_bar = (z_new + z_old)*0.5_rt; |
There was a problem hiding this comment.
As implemented, this will not achieved the desired result. We can talk offline about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the deposition (and field gather), cropping particle orbits at the boundary of the domain for PEC and PMC boundaries. This is a simple way of achieving charge conservation as particles are absorbed at boundaries.
Should this always be done or should a flag be added to turn this feature on?
Only in Villasenor and Buneman current deposition now. Will be extended to Esirkepov.
A second necessary change (with reflective boundaries) is to stop the particle orbits at the boundary so that in the next time step, the particles start at the boundary.