Condense repetitive dashboard code #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
proy30
commented
Jan 6, 2025
proy30
changed the title
Future commit needs to create init_states by section rather than at once call
Dialogs defaults will always be false, not necessary to expicitly state it
…bution and distribution_type This was already changed from selectedDistribution and selectedDistributionType to selected_distribution and distribution_type and this is the second variable name change
variable name change relocte logic
proy30
changed the title
This was referenced Jan 10, 2025
Merged
proy30
changed the title
|
A larger, but necessary dashboard PR. There's still more logic to refine and optimize, but this is a solid starting point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the dashboard contains many repeated logic, especially for UI components. This PR condenses some of the logic so that future input implementations can be easily placed.
Functionality for the dashboard remains the same.