Apply transverse aperture to thick elements. #788

cemitch99 · 2025-01-08T20:34:06Z

Adds the comparison of particles against the transverse aperture within thick elements, at the end of each space charge slice. This will close #763 .

Note: Need to verify that using the same name Aperture for the thin aperture element and for the mixin class will not cause conflicts. Otherwise, one of these should be renamed.

Add namespace amrex::literals

Add Python class for aperture mixin.

for more information, see https://pre-commit.ci

src/particles/elements/Drift.H

for more information, see https://pre-commit.ci

cemitch99 · 2025-01-09T23:33:30Z

Note: Windows test fail now, but all tests were previously passing.

examples/aperture/input_aperture_thick.in

examples/aperture/run_aperture_thick.py

src/particles/elements/mixin/aperture.H

src/particles/elements/Drift.H

src/particles/elements/mixin/aperture.H

src/python/elements.cpp

Small changes (excluding naming and std::optional). Co-authored-by: Axel Huebl <[email protected]>

Remove "maybe unused".

docs/source/usage/parameters.rst

docs/source/usage/python.rst

examples/aperture/input_aperture_thick.in

examples/aperture/run_aperture_thick.py

src/initialization/InitElement.cpp

src/particles/elements/Drift.H

src/python/elements.cpp

src/initialization/InitElement.cpp

cemitch99 · 2025-01-14T00:16:13Z

Problems on Windows after merging in 'development'...
Appears to have resolved.

for more information, see https://pre-commit.ci

docs/source/usage/parameters.rst

docs/source/usage/python.rst

src/initialization/InitElement.cpp

src/particles/elements/Aperture.H

src/particles/elements/mixin/aperture.H

src/python/elements.cpp

ax3l · 2025-01-15T00:06:59Z

src/python/elements.cpp

+             py::arg("aperture_x"),
+             py::arg("aperture_y"),


As above: we could avoid this breaking change for the Aperture element itself.

The break of API arg name here might be ok, for python people might not use the named arguments yet that much.

I'll keep this as breaking change for the Python API.

We do not want to create variables from them.

…s_thick

Mirror directory structure and separate from "physical" elements as we do in Python.

For inputs file.

src/particles/elements/Drift.H

for more information, see https://pre-commit.ci

Co-authored-by: Axel Huebl <[email protected]>

cemitch99 and others added 5 commits January 8, 2025 12:20

Initial files for applying aperture to thick elements.

35eeb95

Update aperture.H

073c87b

Add namespace amrex::literals

Add Python bindings for drift.

960aad9

Update elements.cpp

f764db9

Add Python class for aperture mixin.

[pre-commit.ci] auto fixes from pre-commit.com hooks

ffe74a0

for more information, see https://pre-commit.ci

cemitch99 added this to the Advanced Methods (SciDAC-5) milestone Jan 9, 2025

cemitch99 added the component: elements Elements/external fields label Jan 9, 2025

ax3l self-requested a review January 9, 2025 00:21

ax3l reviewed Jan 9, 2025

View reviewed changes

src/particles/elements/Drift.H Outdated Show resolved Hide resolved

cemitch99 and others added 5 commits January 9, 2025 10:56

Add draft example.

3bf409e

[pre-commit.ci] auto fixes from pre-commit.com hooks

c550b95

for more information, see https://pre-commit.ci

Move if conditional into mixin.

99967d8

Add drift aperture input documentation.

5ff2ee4

[pre-commit.ci] auto fixes from pre-commit.com hooks

578e7f2

for more information, see https://pre-commit.ci

ax3l reviewed Jan 10, 2025

View reviewed changes

cemitch99 and others added 4 commits January 9, 2025 17:08

Apply suggestions from code review

a130d24

Small changes (excluding naming and std::optional). Co-authored-by: Axel Huebl <[email protected]>

Update Drift.H

13980ef

Remove "maybe unused".

Change name xmax -> x_aperture...

0554261

Fix one missing xmax -> x_aperture in elements.cpp.

fb572fe