-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test of IOTA nonlinear magnet model with physical aperture. #802
Merged
cemitch99
merged 10 commits into
ECP-WarpX:development
from
cemitch99:add_example_iota_nll_aperture
Jan 18, 2025
Merged
Test of IOTA nonlinear magnet model with physical aperture. #802
cemitch99
merged 10 commits into
ECP-WarpX:development
from
cemitch99:add_example_iota_nll_aperture
Jan 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Note that build is failing during testing. |
ax3l
reviewed
Jan 18, 2025
examples/iota_lens/README.rst
Outdated
entrance to the nonlinear element, and then again after the thin lens (representing a | ||
single period). These values should be unchanged for all particles (to within acceptable tolerance). | ||
|
||
In this test, the initial and final values of :math:`\mu_H`, :math:`\sigma_H`, :math:`\mu_I`, :math:`\sigma_I` must agree with nominal values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
In this test, the initial and final values of :math:`\mu_H`, :math:`\sigma_H`, :math:`\mu_I`, :math:`\sigma_I` must agree with nominal values. | |
In this test, the initial and final values of :math:`\mu_H`, :math:`\sigma_H`, :math:`\mu_I`, :math:`\sigma_I` and the number of lost particles in apertures must agree with nominal values. |
ax3l
approved these changes
Jan 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Minor suggestion for the test description, feel free to merge when ready.
Co-authored-by: Axel Huebl <[email protected]>
Change objective description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test combines a physical model of the IOTA nonlinear magnetic insert with realistic transverse aperture restrictions.
Follow-up to #795 Adds coverage for #762