Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small additions to data analysis docs. #819

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

cemitch99
Copy link
Member

@cemitch99 cemitch99 commented Jan 29, 2025

This is a minor PR to close #533

It appears that almost all comments were addressed already, but not tracked. Only small changes here.

@cemitch99 cemitch99 requested review from ax3l and n01r January 29, 2025 20:44
@n01r
Copy link
Member

n01r commented Jan 29, 2025

@cemitch99, is this ready for review yet? It looked like that things were still changing while I just had a first look at this PR

@cemitch99
Copy link
Member Author

Yes, this is ready.

Copy link
Member

@n01r n01r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

I had one suggestion but otherwise, I approve.

docs/source/dataanalysis/dataanalysis.rst Outdated Show resolved Hide resolved
@ax3l ax3l added this to the Sirepo (FY24/24 Phase 1 SBIR) milestone Jan 30, 2025
@ax3l ax3l added the component: documentation Docs, readme and manual label Jan 30, 2025
@ax3l ax3l requested a review from SchroederSa January 30, 2025 05:24
@ax3l ax3l merged commit 2d67402 into ECP-WarpX:development Jan 30, 2025
15 of 16 checks passed
Copy link
Contributor

@SchroederSa SchroederSa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Docs, readme and manual
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduced beam diagnostic output - kinetic energy
4 participants