Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang-tidy CI test #56

Merged
merged 88 commits into from
Jan 17, 2025
Merged

Conversation

lucafedeli88
Copy link
Member

@lucafedeli88 lucafedeli88 commented Aug 30, 2024

This PR introduces a new CI test that runs clang-tidy on all the tests and demos of picsar_qed.
Included/excluded clang-tidy checks as well as check options can be found in .clang-tidy. For the moment, this configuration file is identical to what is used in WarpX.

The PR also fixes all the issues found with the new clang-tidy CI test. In order to fix some issues properly, now C++17 is used (up until now the library used C++14)

@lucafedeli88 lucafedeli88 changed the title [WIP] Add clang-tidy CI test Add clang-tidy CI test Oct 30, 2024
Copy link
Member

@EZoni EZoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, all CI checks seem successful, so it's probably ready to merge. I left only two minor notes related to inline comments that might have been copied from WarpX.

.github/workflows/dependencies/clang15.sh Outdated Show resolved Hide resolved
.github/workflows/clang_tidy.yml Outdated Show resolved Hide resolved
@ax3l
Copy link
Member

ax3l commented Jan 17, 2025

Restarting CI because of old PR.
(CI was green, but the last run was 2 months old.)

@ax3l ax3l closed this Jan 17, 2025
@ax3l ax3l reopened this Jan 17, 2025
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that LGTM.

@ax3l
Copy link
Member

ax3l commented Jan 17, 2025

@lucafedeli88 let me know if you like to tag a new 25.02 release at the end of the months again, so we can easily track and pull it into WarpX.

@ax3l ax3l merged commit 47b3939 into ECP-WarpX:development Jan 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants