Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let ingestion script move existing compat layers instead of removing them #176

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

bedroge
Copy link
Collaborator

@bedroge bedroge commented Feb 6, 2024

When ingesting an updated compat layer, this adds a suffix to the existing one instead of removing them.

Example / test on the pilot repo with only /cvmfs/pilot.eessi-hpc.org/versions/2023.06/compat/linux/x86_64 in place:

Compatibility layer for version 2023.06, OS linux, and architecture x86_64 already exists!
Moving the existing compat layer to /cvmfs/pilot.eessi-hpc.org/versions/2023.06/compat/linux/x86_64-001...

Doing it once more with both /cvmfs/pilot.eessi-hpc.org/versions/2023.06/compat/linux/x86_64 and /cvmfs/pilot.eessi-hpc.org/versions/2023.06/compat/linux/x86_64-001 already in place:

Compatibility layer for version 2023.06, OS linux, and architecture x86_64 already exists!
Moving the existing compat layer from /cvmfs/pilot.eessi-hpc.org/versions/2023.06/compat/linux/x86_64 to /cvmfs/pilot.eessi-hpc.org/versions/2023.06/compat/linux/x86_64-002...

This can be used as a first step towards making x86_64 and aarch64 a variant symlink, allowing us to easily switch between compat layer versions (in that case the new one should also get a suffix when it's being ingested; that's not implemented yet). At the moment it doesn't use variant symlinks, nor does it change the path of a newly ingested compat layer, so it shouldn't change/break anything.

scripts/ingest-tarball.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 50f8503 into EESSI:main Feb 6, 2024
21 checks passed
@bedroge bedroge deleted the ingest_mv_old_compat_layer branch February 6, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants