Do not-equal-to comparisons on strings. Versions arent numbers

EESSI · Oct 2, 2024 · 2b98d1e · 2b98d1e
1 parent 0199051
commit 2b98d1e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/automatic_versioning.yml b/.github/workflows/automatic_versioning.yml
@@ -56,7 +56,7 @@ jobs:
             fallback_version=$(grep -oP 'fallback_version\s*=\s*"\K[^"]+' "test-suite-$GITHUB_SHA/pyproject.toml")
 
             echo "Testing if this version is the fallback version from pyproject.toml ..."
-            if [[ "$uninstalled_version" -ne "$fallback_version" ]]; then
+            if [[ "$uninstalled_version" != "$fallback_version" ]]; then
                 exit 1
             else
                 echo "... yes!"
@@ -94,14 +94,14 @@ jobs:
             echo "Version from installed testsuite: $installed_version"
 
             echo "Testing if this is the fallback version from pyproject.toml ..."
-            if [[ "$installed_version" -ne "$fallback_version" ]]; then
+            if [[ "$installed_version" != "$fallback_version" ]]; then
                 exit 1
             else
                 echo "... yes!"
             fi
 
             echo "Checking if the version imported from eessi.testsuite matches that from the version file ..."
-            if [[ "$versionfile_version" -ne "$installed_version" ]]; then
+            if [[ "$versionfile_version" != "$installed_version" ]]; then
                 exit 1
             else
                 echo "... yes!"

diff --git a/.github/workflows/pip_install.yml b/.github/workflows/pip_install.yml
@@ -72,7 +72,7 @@ jobs:
             echo "Version imported from eessi.testsuite: $testsuite_version"
 
             echo "Checking if the version imported from eessi.testsuite matches that from the version file ..."
-            if [[ "$versionfile_version" -ne "$testsuite_version" ]]; then
+            if [[ "$versionfile_version" != "$testsuite_version" ]]; then
                 exit 1
             else
                 echo "... yes!"
@@ -110,14 +110,14 @@ jobs:
             echo "Version imported from eessi.testsuite: $githttps_testsuite_version"
 
             echo "Checking if the version imported from eessi.testsuite matches that from the version file ..."
-            if [[ "$githttps_versionfile_version" -ne "$githttps_testsuite_version" ]]; then
+            if [[ "$githttps_versionfile_version" != "$githttps_testsuite_version" ]]; then
                 exit 1
             else
                 echo "... yes!"
             fi
 
             echo "Checking if the version import from a regular pip install and the git+https based install are the same ..."
-            if [[ "$githttps_testsuite_version" -ne "$testsuite_version" ]]; then
+            if [[ "$githttps_testsuite_version" != "$testsuite_version" ]]; then
                 exit 1
             else
                 echo "... yes!"