SNO-124-make-elasticsearch-shards-configurable #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keenangraham
changed the title
Bek
force-pushed
the
SNO-124-deploy-shard-settings
branch
from
d545033
to
f8dcb87
Compare
keenangraham
approved these changes
Oct 26, 2020
hitz
requested changes
Jan 4, 2021
Comment on lines
+8
to
+9
| elasticsearch.shards.primary = 1 | ||
| elasticsearch.shards.replicate = 0 |
There was a problem hiding this comment.
@keenangraham @Bek I think we should start with adding the ability to configure the shards without actually changing it.
There was a problem hiding this comment.
With version 5, we don’t have the total shards limit and we can leave the default number as before. We should still change it to minimum for single machine demos, what do you think? I will look to it.
There was a problem hiding this comment.
I don't think it matters much on a single-node demo; they already index just as fast and they have a low search load. What difference do you think it would make?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.