This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
build.sh: switch from CMAKE_FRAMEWORK_PATH to CMAKE_MODULE_PATH #503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
CMAKE_FRAMEWORK_PATH is bad as it's read by cmake but it is not available in cmake scripts.
Also according to the documentation this variable should contain path to OS X frameworks.
CMAKE_MODULE_PATH is the right way to go.
By adding this code to CMakeLists.txt (line 78 in this case):
And run:
$ export CMAKE_FRAMEWORK_PATH=/usr/opt/eosio.cdt/1.7 $ cmake ..
You get the following output:
Deployment Changes
API Changes
Documentation Additions