Known-issue turn expected test fail into a pass in ReFrame #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fortran formatting Added project details to the .toml file
|
Currently, The errors are: rapostol@ln02:> ftn gcc_mpi_f08.f90 -o ./InterfaceBoundsTest
F90-S-0034-Syntax error at or near * (gcc_mpi_f08.f90: 4)
0 inform, 0 warnings, 1 severes, 0 fatal for foo
F90-S-0034-Syntax error at or near * (gcc_mpi_f08.f90: 9)
0 inform, 0 warnings, 1 severes, 0 fatal for dummy
F90-S-0446-Argument number 1 to dummy: rank mismatch (gcc_mpi_f08.f90: 27)
F90-S-0446-Argument number 1 to dummy: rank mismatch (gcc_mpi_f08.f90: 36)
0 inform, 0 warnings, 2 severes, 0 fatal for main |
My recollection is that AOCC flang could compile it but it showed the same error as GCC but I have not looked closely for a while. It could be this changed with the newer version of AOCC. |
I haven't been able to compile this program at all with |
|
OK, whether my recollection is right or not, we are here now. Should we exclude AOCC from the test or let it fail in this way? |
|
My vote is to remove - no point in cluttering ReFrame's output with "fails" when nothing is actually wrong. |
|
@aturner-epcc I've removed Here are the test outputs. First for ARCHER2: rapostol@ln03:~/work/epcc-reframe> reframe -r -C configuration/archer2.py -c tests/known-issues/gcc_mpi_f08/gcc_mpi_f08.py
[ReFrame Setup]
version: 4.2.1
command: '/work/y07/shared/utils/core/reframe/4.2.1/bin/reframe --keep-stage-files -r -C configuration/archer2.py -c tests/known-issues/gcc_mpi_f08/gcc_mpi_f08.py'
launched by: rapostol@ln03
working directory: '/mnt/lustre/a2fs-work2/work/z19/z19/rapostol/epcc-reframe'
settings files: '<builtin>', 'configuration/archer2.py'
check search path: '/mnt/lustre/a2fs-work2/work/z19/z19/rapostol/epcc-reframe/tests/known-issues/gcc_mpi_f08/gcc_mpi_f08.py'
stage directory: '/mnt/lustre/a2fs-work2/work/z19/z19/rapostol/epcc-reframe/stage'
output directory: '/mnt/lustre/a2fs-work2/work/z19/z19/rapostol/epcc-reframe/output'
log files: '/mnt/lustre/a2fs-work2/work/z19/z19/rapostol/epcc-reframe/reframe.out', '/mnt/lustre/a2fs-work2/work/z19/z19/rapostol/epcc-reframe/reframe.log'
[==========] Running 1 check(s)
[==========] Started on Thu Sep 12 16:23:26 2024
[----------] start processing checks
[ RUN ] InterfaceBoundsTest %lang=f90 /14a869c6 @archer2:login+Default
[ RUN ] InterfaceBoundsTest %lang=f90 /14a869c6 @archer2:login+PrgEnv-gnu
[ RUN ] InterfaceBoundsTest %lang=f90 /14a869c6 @archer2:login+PrgEnv-cray
[ OK ] (1/3) InterfaceBoundsTest %lang=f90 /14a869c6 @archer2:login+Default
[ OK ] (2/3) InterfaceBoundsTest %lang=f90 /14a869c6 @archer2:login+PrgEnv-gnu
[ OK ] (3/3) InterfaceBoundsTest %lang=f90 /14a869c6 @archer2:login+PrgEnv-cray
[----------] all spawned checks have finished
[ PASSED ] Ran 3/3 test case(s) from 1 check(s) (0 failure(s), 0 skipped, 0 aborted)
[==========] Finished on Thu Sep 12 16:23:29 2024
Log file(s) saved in '/mnt/lustre/a2fs-work2/work/z19/z19/rapostol/epcc-reframe/reframe.out', '/mnt/lustre/a2fs-work2/work/z19/z19/rapostol/epcc-reframe/reframe.log'and for Cirrus: rapostol@cirrus-login2:~/work/reframe_dev$ reframe -r -C configuration/cirrus.py -c tests/known-issues/gcc_mpi_f08/gcc_mpi_f08.py
[ReFrame Setup]
version: 4.6.0-dev.1
command: '/work/y07/shared/cirrus-software/reframe/bin/reframe -r --keep-stage-files -C configuration/cirrus.py -c tests/known-issues/gcc_mpi_f08/gcc_mpi_f08.py'
launched by: rapostol@cirrus-login2
working directory: '/mnt/lustre/e1000/home/z04/z04/rapostol/reframe_dev'
settings files: '<builtin>', 'configuration/cirrus.py'
check search path: '/mnt/lustre/e1000/home/z04/z04/rapostol/reframe_dev/tests/known-issues/gcc_mpi_f08/gcc_mpi_f08.py'
stage directory: '/mnt/lustre/e1000/home/z04/z04/rapostol/reframe_dev/stage'
output directory: '/mnt/lustre/e1000/home/z04/z04/rapostol/reframe_dev/output'
log files: '/mnt/lustre/e1000/home/z04/z04/rapostol/reframe_dev/reframe.out', '/mnt/lustre/e1000/home/z04/z04/rapostol/reframe_dev/reframe.log'
[==========] Running 1 check(s)
[==========] Started on Thu Sep 12 16:23:20 2024+0100
[----------] start processing checks
[ RUN ] InterfaceBoundsTest %lang=f90 /14a869c6 @cirrus:login+Default
[ RUN ] InterfaceBoundsTest %lang=f90 /14a869c6 @cirrus:login+gcc
[ RUN ] InterfaceBoundsTest %lang=f90 /14a869c6 @cirrus:login+intel
[ OK ] (1/3) InterfaceBoundsTest %lang=f90 /14a869c6 @cirrus:login+Default
[ OK ] (2/3) InterfaceBoundsTest %lang=f90 /14a869c6 @cirrus:login+gcc
[ OK ] (3/3) InterfaceBoundsTest %lang=f90 /14a869c6 @cirrus:login+intel
[----------] all spawned checks have finished
[ PASSED ] Ran 3/3 test case(s) from 1 check(s) (0 failure(s), 0 skipped, 0 aborted)
[==========] Finished on Thu Sep 12 16:23:38 2024+0100
Log file(s) saved in '/mnt/lustre/e1000/home/z04/z04/rapostol/reframe_dev/reframe.out', '/mnt/lustre/e1000/home/z04/z04/rapostol/reframe_dev/reframe.log'I think this is ready to be reviewed, I'll change it from draft to PR. |
|
Retested this on cirrus and archer2 myself and reproduced results before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the "fail" on the gcc test a pass on ReFrame - this way no fails are reported as long as the situation is constant.
If the situation changes, the test will fail, and we can update our documentation.
Also changed:
Fortran formatting
Added project details to the .toml file