New tests to check pm counters are accessible and reporting #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aturner-epcc
requested changes
Sep 25, 2024
tests/env/counters_check.py
Outdated
|
|
||
| descr = "Checks whether the node energy pm counter is accessible and reporting" | ||
| valid_systems = ["archer2:compute"] | ||
| valid_prog_environs = ["PrgEnv-cray", "PrgEnv-gnu", "PrgEnv-aocc"] |
There was a problem hiding this comment.
I think you should only choose a single PrgEnv otherwise each test will be run three times in an identical fashion
There was a problem hiding this comment.
done an PR updated
There was a problem hiding this comment.
Does it need PrgEnv-cray or could it be Default?
https://github.com/EPCCed/epcc-reframe/blob/518b1227148f8c47eebe8d7245fb05443a4831bd/configuration/archer2.py#L147C21-L147C22
There was a problem hiding this comment.
Ignore me, the Default environment is only valid for the login partition.
There was a problem hiding this comment.
@aturner-epcc happy this is resolved?
RuiApostolo
approved these changes
Sep 25, 2024
aturner-epcc
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for pm counters added: