Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect bound checks #2040

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Fix incorrect bound checks #2040

merged 3 commits into from
Nov 18, 2024

Conversation

fwesselm
Copy link
Contributor

Fix incorrect signs when comparing with kHighsInf.

Copy link
Member

@jajhall jajhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I guess the first case doesn't matter, as rounding -inf gives -inf.

If the second was used in error, I guess it might have shown up spectacularly, but I'd have to follow through the subsequent actions properly

@fwesselm
Copy link
Contributor Author

Interesting. I guess the first case doesn't matter, as rounding -inf gives -inf.

If the second was used in error, I guess it might have shown up spectacularly, but I'd have to follow through the subsequent actions properly

I can also run the entire test suite for this change, if you like. Just to see if any problem is affected...

@fwesselm
Copy link
Contributor Author

Interesting. I guess the first case doesn't matter, as rounding -inf gives -inf.
If the second was used in error, I guess it might have shown up spectacularly, but I'd have to follow through the subsequent actions properly

I can also run the entire test suite for this change, if you like. Just to see if any problem is affected...

I started testing and will report back tomorrow.

@jajhall
Copy link
Member

jajhall commented Nov 18, 2024

Failure is due to odd behaviour for new CI test

@jajhall jajhall merged commit 5115f46 into ERGO-Code:latest Nov 18, 2024
103 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants