-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Standard Name Rules table for dimensionless units, change variables improperly using "1" to "fraction" #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this @mkavulich! Would you be willing to add a couple extra unit changes to this PR? Specifically the following:
cellular_automata_seed_probability
currently has units offraction
. Might be worth changing that tofrac
.chemical_tracer_scavenging_fractions
should probably also have units offrac
.
Otherwise I think everything else looks good, at least to me.
Why can we not spell out fraction? We also spell out percent. The 8-character limit in F77 is history! |
@climbfuji I'm just going off the existing conventions; all the schemes in ccpp-physics currently use |
I'm personally fine with either |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay for me
If it's not too much work, can you change all |
@nusbaume @climbfuji I have made the suggested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for considering my comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me now, thanks!
Related to Issue #26 and discussion therein, this PR updates the Standard Name Rules table for dimensionless units, removing some ambiguity in wording, separating out "frac" from "percent" entries (since fractions and percentages are different things, and can theoretically be converted) and clarifying when "1" should be used. In addition, several standard names that reference fractions are updated to appropriately use "frac" rather than "1".