Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cesm2.2-asdbranch_slh (Rafa Fernandez) #267

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

RafaPedroFernandez
Copy link

Description of changes

The new cesm2.2-asdbranch_slh branch contains development related to Short-Lived Halogen (SLH) chemistry in the Troposphere and Stratosphere.

Specific notes

This is my first time using git/github. Please let me know if there is something else I can do.

Contributors other than yourself, if any:
SLH Team in Madrid (PI Alfonso Saiz-Lopez); Doug Kinnison, Francis Vitt

Fixes: [Github issue #s] And brief description of each issue.

User interface changes?: [ No/Yes ]
[ If yes, describe what changed, and steps taken to ensure backward compatibility ]

Testing performed (automated tests and/or manual tests):

billsacks and others added 24 commits September 15, 2020 13:12
Update documentation for CESM2.2.0.

Juggled around CESM vs CESM2. The approach I took was if it applied to both
CESM and CESM2, I left it as CESM. For example the section on inputdata, and version
naming. If something applied to only CESM2, I changed CESM to CESM2. An example
of this is the download instructions and different components.

In the download instructions, I needed to update the manage_externals -S output to reflect
the changes of the option components. Then included a note that this is the default and
CESM2 will still run.
Document compset first letter convention

Equivalent to ESCOMP#187 but for this
release branch.
@jedwards4b
Copy link
Contributor

@RafaPedroFernandez @fvitt perhaps we should talk about this - Do you want this code in cesm2.2 (which is a dead branch of cesm) or do you want it in the latest development?

@RafaPedroFernandez
Copy link
Author

@RafaPedroFernandez @fvitt perhaps we should talk about this - Do you want this code in cesm2.2 (which is a dead branch of cesm) or do you want it in the latest development?

Thanks Jim for your response. We'd like to implement SLH chemistry in CESM2.2. This is something we agreed with Doug Kinnison and Simone Tilmes. Note these SLH developments have only been previously used in CESM1.

Note that most of the changes in *.F90 routines and configuration files were performed in the CAM repository ... but I was not able to do a pull request from my personal forked version (cam_cesm2_2_rel_09_slh). I'm not sure how to do it.
https://github.com/RafaPedroFernandez/CAM/tree/cam_cesm2_2_rel_09_slh

Happy to talk about it with you and @fvitt at any time.
Thanks in advance

@jedwards4b
Copy link
Contributor

It looks like @fvitt is out this week - do you want to get another CAM developer involved or wait until he returns next week?

@RafaPedroFernandez
Copy link
Author

I prefer to wait until @fvitt is available as he has been our reference on many model implementations. Thanks !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants