-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow lai streams with FATES #2054
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fates_lai_streams
ekluzek
added
FATES
A change needed for FATES that doesn't require a FATES API update.
enhancement
new capability or improved behavior of existing capability
tag: enh - new science
labels
Sep 12, 2023
ekluzek
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I have one question about a build-namelist thing...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
new capability or improved behavior of existing capability
FATES
A change needed for FATES that doesn't require a FATES API update.
science
Enhancement to or bug impacting science
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Removed checks in
clm_driver
andCLMBuildNamelist.pm
so that now FATES can run whenuse_lai_streams=.true.
.Specific notes
I also had to modify the init in
cpl/share_esmf/laiStreamMod
to allocate theg_to_ig
array in thelai_init
method (rather than in thelai_advance
method. This was required becauseSatellitePhenology
is called inclim_initializedMod
in FATES cases (here). This happens beforelai_advance
is ever called so at that point theg_to_ig
array was not yet allocated. Moving the allocation/initialization to thelai_init
method fixes this.Contributors other than yourself, if any: @ekluzek
CTSM Issues Fixed (include github issue #):
Fixes #1722
Are answers expected to change (and if so in what way)?
No
Any User Interface Changes (namelist or namelist defaults changes)?
No
Testing performed, if any:
Lai streams test with big leaf CLM was B4B (/glade/scratch/afoster/ERP_D_Ld3_PS.f09_g17.I2000Clm50Sp.cheyenne_intel.clm-prescribed.C.20230712_095955_yillab)
FATES test suite all passed:
/glade/scratch/afoster/tests_0725-145314ch