Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lai streams with FATES #2054

Merged
merged 40 commits into from
Sep 12, 2023
Merged

Conversation

adrifoster
Copy link
Collaborator

@adrifoster adrifoster commented Jul 12, 2023

Description of changes

Removed checks in clm_driver and CLMBuildNamelist.pm so that now FATES can run when use_lai_streams=.true..

Specific notes

I also had to modify the init in cpl/share_esmf/laiStreamMod to allocate the g_to_ig array in the lai_init method (rather than in the lai_advance method. This was required because SatellitePhenology is called in clim_initializedMod in FATES cases (here). This happens before lai_advance is ever called so at that point the g_to_ig array was not yet allocated. Moving the allocation/initialization to the lai_init method fixes this.

Contributors other than yourself, if any: @ekluzek

CTSM Issues Fixed (include github issue #):
Fixes #1722

Are answers expected to change (and if so in what way)?
No

Any User Interface Changes (namelist or namelist defaults changes)?
No

Testing performed, if any:
Lai streams test with big leaf CLM was B4B (/glade/scratch/afoster/ERP_D_Ld3_PS.f09_g17.I2000Clm50Sp.cheyenne_intel.clm-prescribed.C.20230712_095955_yillab)

FATES test suite all passed:

/glade/scratch/afoster/tests_0725-145314ch

0725-145314ch_gnu: 3 tests
    FAIL ERS_Lm13.f10_f10_mg37.I2000Clm50Fates.cheyenne_gnu.clm-FatesCold COMPARE_base_rest (EXPECTED FAILURE)

 
0725-145314ch_int: 34 tests
    PEND ERP_P72x2_Ld30.f45_f45_mg37.I2000Clm50FatesRs.cheyenne_intel.clm-mimicsFatesCold SHAREDLIB_BUILD (EXPECTED FAILURE)
    FAIL ERS_D_Ld5.1x1_brazil.I2000Clm50FatesCruRsGs.cheyenne_intel.clm-FatesColdHydro COMPARE_base_rest (EXPECTED FAILURE)
    FAIL ERS_Lm12.1x1_brazil.I2000Clm50FatesCruRsGs.cheyenne_intel.clm-FatesFireLightningPopDens COMPARE_base_rest (EXPECTED FAILURE)
    FAIL ERS_Lm13.f45_f45_mg37.I2000Clm50Fates.cheyenne_intel.clm-FatesColdNoComp COMPARE_base_rest (EXPECTED FAILURE)
    FAIL SMS_Ld3.f09_g17.I2000Clm51FatesSpCruRsGs.cheyenne_intel.clm-FatesColdSatPhen_prescribed NLCOMP
    FAIL SMS_Ld3.f09_g17.I2000Clm51FatesSpCruRsGs.cheyenne_intel.clm-FatesColdSatPhen_prescribed BASELINE fates-sci.1.66.1_api.25.5.0-ctsm5.1.dev130: ERROR BFAIL baseline directory '/glade/p/cgd/tss/ctsm_baselines/fates-sci.1.66.1_api.25.5.0-ctsm5.1.dev130/SMS_Ld3.f09_g17.I2000Clm51FatesSpCruRsGs.cheyenne_intel.clm-FatesColdSatPhen_prescribed' does not exist

 
========================================================================
Non-PASS results for select phases:
TPUTCOMP non-passes: 0
MEMCOMP non-passes: 0

@ekluzek ekluzek added FATES A change needed for FATES that doesn't require a FATES API update. enhancement new capability or improved behavior of existing capability tag: enh - new science labels Sep 12, 2023
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I have one question about a build-namelist thing...

bld/CLMBuildNamelist.pm Outdated Show resolved Hide resolved
@ekluzek ekluzek merged commit 72b60f8 into ESCOMP:master Sep 12, 2023
2 checks passed
@ekluzek ekluzek deleted the fates_lai_streams branch September 12, 2023 21:22
@samsrabin samsrabin added the science Enhancement to or bug impacting science label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability FATES A change needed for FATES that doesn't require a FATES API update. science Enhancement to or bug impacting science
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should be able to use lai streams with FATES-SP mode
3 participants