Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve some users' errors with Python tests #2062

Closed
wants to merge 3 commits into from
Closed

Resolve some users' errors with Python tests #2062

wants to merge 3 commits into from

Conversation

samsrabin
Copy link
Collaborator

@samsrabin samsrabin commented Jul 17, 2023 •
edited
Loading

Description of changes

This resolves two issues:

Specific notes

Contributors other than yourself, if any: @billsacks

CTSM Issues Fixed (include github issue #): #2042

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed, if any:

  • python/run_ctsm_py_tests all pass
  • clm_pymods test suite passes on cheyenne

@samsrabin
TestSysMeshMaskModifier now properly leaves temp dir before removing it.
c659092
@samsrabin
FSURDATMODIFYCTSM test now uses conda run -n instead of `conda acti…
76d6cfc 
…vate`.

This is a more robust method and is recommended when conda is being used non-interactively. RXCROPMATURITY already used this method, so I introduced a new module in cime_config/SystemTests, systemtests_utils.py, to share the code.
* Resolves ESCOMP#2042
@samsrabin samsrabin added tag: simple bfb bug something is working incorrectly labels Jul 17, 2023
@samsrabin samsrabin requested a review from billsacks July 17, 2023 19:38
@samsrabin samsrabin self-assigned this Jul 17, 2023
@samsrabin samsrabin marked this pull request as ready for review July 17, 2023 19:48
@samsrabin samsrabin mentioned this pull request Jul 17, 2023
Merged
@samsrabin
Copy link
Collaborator Author

@ekluzek, could you please have a look at my temporary ChangeLog file to make sure the entry looks all right? Thanks!

@samsrabin samsrabin requested review from ekluzek and removed request for billsacks July 17, 2023 22:54
@samsrabin samsrabin added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jul 18, 2023
@samsrabin samsrabin added the PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete label Jul 27, 2023
@samsrabin
Copy link
Collaborator Author

Included in #1863.

@samsrabin samsrabin closed this Jul 27, 2023
@samsrabin samsrabin removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Mar 21, 2024
@samsrabin samsrabin added simple bfb bit-for-bit labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekluzek ekluzek Awaiting requested review from ekluzek

Assignees

@samsrabin samsrabin

Labels
bfb bit-for-bit bug something is working incorrectly PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsrabin