Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing ne0CONUS, ne0ARCTIC tests #2805

Draft
wants to merge 8 commits into
base: b4b-dev
Choose a base branch
from

Conversation

slevis-lmwg
Copy link
Contributor

@slevis-lmwg slevis-lmwg commented Oct 2, 2024

Description of changes

Following the TODO list posted in the issue #2544.
My local branch is located here:
/glade/work/slevis/git/mksurfdata_toolchain/

When #2544 works, I will repeat for #2548.

Specific notes

Contributors other than yourself, if any:
@ekluzek

CTSM Issues Fixed (include github issue #):
Resolves #2544
Resolves #2548

Are answers expected to change (and if so in what way)?
No.

Any User Interface Changes (namelist or namelist defaults changes)?
Yes, to get relevant tests passing.

Does this create a need to change or add documentation? Did you do so?
No.

Testing performed, if any:
PASS SMS_Ln9.ne0CONUSne30x8_ne0CONUSne30x8_mt12.IHistClm50Sp.derecho_intel.clm-clm50cam6LndTuningMode_2013Start
PASS SMS_Ln9.ne0ARCTICne30x4_ne0ARCTICne30x4_mt12.IHistClm50Sp.derecho_intel.clm-clm50cam6LndTuningMode_1979Start
PASS build-namelist_test.pl with the suggested modification adding a 20thC_transient CONUS test.

@slevis-lmwg tracking sprint in #2544

@slevis-lmwg slevis-lmwg changed the base branch from master to b4b-dev October 2, 2024 00:32
@slevis-lmwg slevis-lmwg self-assigned this Oct 2, 2024
@slevis-lmwg slevis-lmwg added the bfb bit-for-bit label Oct 2, 2024
@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Oct 2, 2024

@ekluzek
I very easily got the SMS...CONUS test to PASS with the commit that you see in this PR.
I did nothing additional for the SMS...ARCTIC test to PASS.

HOWEVER, I spent all day making countless attempts to get build-namelist_test.pl to work with the change that makes the CONUS test "20thC_transient". None of my attempts worked, so I will stop wasting time on this until we go over it together.

UPDDATE: build-namelist_test.pl now works with the most recent commits.

@slevis-lmwg

This comment was marked as resolved.

@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Oct 17, 2024

The checklist in issue #2544 asks whether we have 20thC tests in build-namelist_test.pl for f19. The answer is yes, so I will check that off.

The conversation about f19 also suggests that #2834 may fix a 16-pft problem in a CAM test, so I'm adding an f19 -no-crop test to our build-namelist tests.

@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Oct 17, 2024

Submitted these manual tests:

PASS SMS_Ln9.f19_f19_mg17.IHistClm50Sp.derecho_intel.clm-clm50cam7LndTuningMode_1979Start--clm-nofireemis

PASS SMS_Ln9.ne0CONUSne30x8_ne0CONUSne30x8_mt12.IHistClm50Sp.derecho_intel.clm-clm50cam7LndTuningMode_2013Start--clm-nofireemis
PASS SMS_Ln9.ne0CONUSne30x8_ne0CONUSne30x8_mt12.IHistClm60Sp.derecho_intel.clm-clm60cam7LndTuningMode_2013Start--clm-nofireemis

PASS SMS_Ln9.ne0ARCTICne30x4_ne0ARCTICne30x4_mt12.IHistClm50Sp.derecho_intel.clm-clm50cam7LndTuningMode_1979Start
PASS SMS_Ln9.ne0ARCTICne30x4_ne0ARCTICne30x4_mt12.IHistClm60Sp.derecho_intel.clm-clm60cam7LndTuningMode_1979Start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ne0ARCTICne30x4 grid transient failure Failing ne0CONUSne30x8_ne0CONUSne30x8_mt12 in CESM testing
1 participant