Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bugfixes from GFDL to main (2024-11-27) #220

Open
gustavo-marques opened this issue Jan 15, 2025 · 0 comments
Open

Enable bugfixes from GFDL to main (2024-11-27) #220

gustavo-marques opened this issue Jan 15, 2025 · 0 comments

Comments

@gustavo-marques
Copy link
Collaborator

The following bug fixes, introduced in GFDL to main (2024-11-27), affect CESM:

* VISC_REM_BUG = True             !   [Boolean] default = True
                                ! If true, visc_rem_[uv] in split mode is incorrectly calculated or accounted
                                ! for in two places. This parameter controls the defaults of two individual
                                ! flags, VISC_REM_TIMESTEP_BUG in MOM_dynamics_split_RK2(b) and
                                ! VISC_REM_BT_WEIGHT_BUG in MOM_barotropic.
* FRICTWORK_BUG = True            !   [Boolean] default = True
                                ! If true, retain an answer-changing bug in calculating the FrictWork, which
                                ! cancels the h in thickness flux and the h at velocity point. This isnot
                                ! recommended.

These are set to True (use the buggy code) by default, so we must set them to False.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant