Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More miscellaneous runtime parameter changes for beta05 #219

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

More miscellaneous runtime parameter changes for beta05 #219

wants to merge 11 commits into from

Conversation

gustavo-marques
Copy link
Collaborator

@gustavo-marques gustavo-marques commented Jan 8, 2025 •
edited
Loading

  • Adds new topographic edits and updated channel list. These lead to slightly improved circulation and hydrograph (Response to bathymetry edits NCAR/omwg_dev#55)
  • Enabled COMPUTE_MONIN_OBUKHOV = True to improve the OBL seasonal cycle by limiting the OBL depth to no deeper than the Monin-Obukhov depth. Because of this change, we now need to assure that OBL is always >= than the first thickness (dz) used in the model. This is done by setting MINIMUM_OBL_DEPTH = 2.5.
  • Updated background mixing parameters:
    • KV = 1.0E06
    • KD = 1.0E-7
    • PRANDTL_BKGND = 10
  • Enable bug fixes introduced in GFDL to main (2024-11-27) mom-ocean/MOM6#1647

Fixes: #218, #213, #208, #220

@gustavo-marques
Update tx2_3v2 defaults for beta05
468da8c 
- Added new topographic edits and updated channel list.
- Enabled COMPUTE_MONIN_OBUKHOV = True to improve the OBL seasonal cycle by limiting the OBL depth to no deeper than the Monin-Obukhov depth.
- Updated background mixing parameters:
  - KV = 1.0E-6
  - KD = 1.0E-7
  - PRANDTL_BKGND = 10
- Configured MLE backup settings:
  - Set MLE_FRONT_LENGTH_FROM_FILE = True
  - Updated MLE_FL_FILE to "mle-lf-clim-tx2_3v2_20250108.nc"
- Enabled Leithy parameterization with:
  - USE_LEITHY = True
  - LEITH_BI_CONST = 90.0
  - LEITHY_CK = 1.0 (full backscatter)
  - LEITH_AH = False
@gustavo-marques
Merge branch 'main' into new_params_beta05
dbd7ddd
@gustavo-marques
Copy link
Collaborator Author

I will add the new files to input_data_list.yaml later today.

@gustavo-marques
Copy link
Collaborator Author

I've added MINIMUM_OBL_DEPTH = 2.5 for cases using tx2_3v2. This solves the issue with the GNU debug test reported in NCAR/MOM6#331

@gustavo-marques gustavo-marques mentioned this pull request Jan 13, 2025
Open
@alperaltuntas
Copy link
Member

Thanks, @gustavo-marques. I'll re-run the test suite.

alperaltuntas
alperaltuntas requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@alperaltuntas alperaltuntas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dimensional scaling test for the L dimension fails when this PR gets merged. I am investigating.

@alperaltuntas
Copy link
Member

@gustavo-marques Is this ready for testing now?

@gustavo-marques
Copy link
Collaborator Author

Yes, thanks!

@gustavo-marques
Copy link
Collaborator Author

With the latest beta05 update, we are getting negative Laplacian viscosities near coastlines. @iangrooms thinks this is a bug; fixing it will take a few days (perhaps more). To avoid additional delays in tag creation, we suggest going back to LEITH_AH.

I am also reverting to using a constant frontal length scale for MLE. As Gokhan pointed out yesterday, the MLE overturning with the variable frontal scale is too strong, reverting the near-surface residual MOC in the Southern Ocean (see plot below).
For now, including this in the tag does not make sense.

image

@gustavo-marques
Copy link
Collaborator Author

I updated the initial description by removing the following:

  • Configured MLE settings (this relies on PR #331):
    • Set MLE_FRONT_LENGTH_FROM_FILE = True
    • Updated MLE_FL_FILE to "mle-lf-clim-tx2_3v2_20250115.nc"
  • Enabled Leithy parameterization with:
    • USE_LEITHY = True
    • LEITH_BI_CONST = 90.0
    • LEITHY_CK = 1.0 (full backscatter)
    • LEITH_AH = False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperaltuntas alperaltuntas alperaltuntas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to specify MLE fronal-length scale via file
2 participants
@gustavo-marques @alperaltuntas