Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI in MOM_interface so that "check_standalone_mom_build_and_run_lightweight_examples" works on MOM_interface forks #234

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

manishvenu
Copy link
Collaborator

The check_standalone_mom_build_and_run_lightweight_examples previously worked by checking out the CESM, cd to the MOM_interface subfolder and checking out the active branch/pr. This logic of checking out MOM_interface does not work if the CI is on a different fork because the CESM only checks out ESCOMP/MOM_interface. The changes made here checks out the correct MOM_interface, and copies it over to the CESM for testing.

  1. Add a step to check out MOM_interface to a temp folder
  2. Replace the previous MOM_interface checkout with cp command to copy MOM_interface into the CESM folder.
  3. Move the submodule consistency check before the MOM_interface checkout stage

Copy link
Collaborator

@mnlevy1981 mnlevy1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recently added a check to this CI to make sure that git fleximod checks out the correct submodules -- does this PR still run that test? We don't need to maintain the exact mechanism used previously, I just want to make sure this test will fail if the .gitmodules file tells git fleximod to check out a different tag than is checked out with git clone --recurse-submodules

@manishvenu
Copy link
Collaborator Author

We recently added a check to this CI to make sure that git fleximod checks out the correct submodules -- does this PR still run that test? We don't need to maintain the exact mechanism used previously, I just want to make sure this test will fail if the .gitmodules file tells git fleximod to check out a different tag than is checked out with git clone --recurse-submodules

Hey Mike, it should. I talked to Alper and moved that submodule consistency check up one step. It still does the check right after the CESM checkout but before we copy the current MOM_interface over into the CESM, which should still work out with what we want the test. It's just supposed to check that the current CESM checkout is doing the correct thing right? Nothing to do with whatever development is happening in the PR/Push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants