Add public Config.update_from_dirs() method
#2538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2538 +/- ##
==========================================
+ Coverage 94.90% 94.91% +0.01%
==========================================
Files 251 251
Lines 14295 14301 +6
==========================================
+ Hits 13566 13574 +8
+ Misses 729 727 -2 ☔ View full report in Codecov by Sentry. |
bouweandela
reviewed
Oct 2, 2024
Co-authored-by: Bouwe Andela <[email protected]>
bouweandela
approved these changes
Oct 3, 2024
valeriupredoi
approved these changes
Oct 3, 2024
|
|
||
| """ | ||
| new_config_dict = self._get_config_dict_from_dirs(dirs) | ||
| merged_config_dict = dask.config.merge(self, new_config_dict) |
There was a problem hiding this comment.
when this throws a wobbly, do you want to catch and release that or filter it through our own custom exception? Just looked at both merge and update from Dask, and they're really basic, and do not account for any possible exception, so if there are exceptions, then those will be cryptic AF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on making ESMValTool with the new configuration (#2448) I noticed that we are missing a simple public function to update the configuration from one or more directories.
This PR adds that.
Related to #2371
Link to documentation: https://esmvaltool--2538.org.readthedocs.build/projects/ESMValCore/en/2538/api/esmvalcore.config.html#esmvalcore.config.Config.update_from_dirs
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: