Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more modern conditional flags in environment.devenv.yml file #124

Closed
wants to merge 1 commit into from

Conversation

nicoddemus
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Merging #124 (f374cf6) into master (6cc9912) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files           7        7           
  Lines         532      532           
=======================================
  Hits          527      527           
  Misses          5        5           

@nicoddemus nicoddemus closed this Dec 29, 2023
@nicoddemus nicoddemus deleted the fb-ASIM-5549-use-locks branch December 29, 2023 14:34
@prusse-martin
Copy link
Member

I am just curious about it.

Given all tests did pass.
Why this was not merged?

@nicoddemus
Copy link
Member Author

I ended up closing this branch for other reasons, but in the end this change went into #125.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants