Merge pull request #45 from ESSS/fb-DTWIN-1492-serialchemy-pre-commit

Make the environment use the most common pre-commit package to avoid adding two and fix syntax warning
ESSS · Dec 6, 2023 · 87f002b · 87f002b
2 parents 568b733 + 64b9dae
commit 87f002b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/environment.devenv.yml b/environment.devenv.yml
@@ -4,7 +4,7 @@ name: serialchemy-py{{ PY }}
 dependencies:
   - black>=19.3b0
   - mypy
-  - pre_commit
+  - pre-commit
   - pytest
   - pytest-cov
   - pytest-datadir

diff --git a/src/serialchemy/_tests/test_nested_fields.py b/src/serialchemy/_tests/test_nested_fields.py
@@ -96,7 +96,7 @@ def setup(model, db_session):
 def test_custom_serializer(model, serializer_strategy, db_session, data_regression):
     serializer_class = (
         getEmployeeSerializerNestedModelFields(model)
-        if serializer_strategy is "NestedModelFields"
+        if serializer_strategy == "NestedModelFields"
         else EmployeeSerializerNestedAttrsFields
     )
     emp = db_session.query(model.Employee).get(1)