Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add call to super() on log_addition, log_change and log_deletion #281

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

haniffm
Copy link

@haniffm haniffm commented Mar 21, 2019

No description provided.

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #281 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   53.55%   53.48%   -0.08%     
==========================================
  Files         158      158              
  Lines       11399    11414      +15     
  Branches     1477     1477              
==========================================
  Hits         6105     6105              
- Misses       5102     5117      +15     
  Partials      192      192
Flag Coverage Δ
#backend 53.48% <0%> (-0.08%) ⬇️
Impacted Files Coverage Δ
ESSArch_Core/auth/admin.py 56.74% <0%> (-5.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d41a3b...eda63be. Read the comment docs.

Copy link
Contributor

@OskarPersson OskarPersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log_addition and log_change are called after the action has been successful, update the log messages accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants