Improve slider body generation

EVAST9919 · Mar 30, 2024 · e7a29d7 · e7a29d7
1 parent ccc984c
commit e7a29d7
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/osu.Game.Rulesets.Bosu/Extensions/ConversionExtensions.cs b/osu.Game.Rulesets.Bosu/Extensions/ConversionExtensions.cs
@@ -132,13 +132,22 @@ public static IEnumerable<BosuHitObject> GenerateSliderBody(double startTime, IH
         {
             List<InstantCherry> bodyCherries = new List<InstantCherry>();
 
-            var bodyCherriesCount = Math.Min(curve.Distance * (curve.RepeatCount + 1) / 15, max_visuals_per_slider_span * (curve.RepeatCount + 1));
+            var bodyCherriesCount = (int)(curve.Distance * (curve.RepeatCount + 1) / 15);
+
+            Vector2 lastPosition = new Vector2(-10000, -10000);
 
             for (int i = 0; i < bodyCherriesCount; i++)
             {
-                var progress = i / bodyCherriesCount;
-                var position = curve.CurvePositionAt(progress) + originalPosition;
-                position = toPlayfieldSpace(position * new Vector2(1, 0.4f));
+                var progress = i / (float)bodyCherriesCount;
+                Vector2 position = toPlayfieldSpace((curve.CurvePositionAt(progress) + originalPosition) * new Vector2(1, 0.4f));
+
+                if (i != 0 && i != bodyCherriesCount - 1)
+                {
+                    if (Vector2.Distance(position, lastPosition) < 5)
+                        continue;
+                }
+
+                lastPosition = position;
 
                 if (withinPlayfield(position))
                 {