Changes for JOSS reviewing process #100
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First, a quality-of-life improvement with adding an issue template. |
|
That seems good to me. I suppose we could add the original S-L description in the 1999 paper, but the recent other paper(s) are more complete and refer to the 1999 paper, and that paper doesn't describe EXP per se. |
The9Cat
reviewed
Jan 23, 2025
There was a problem hiding this comment.
I wonder if we want:
find_package(Eigen3 3.4...<3.5 REQUIRED)
The9Cat
reviewed
Jan 23, 2025
There was a problem hiding this comment.
I wonder if we need to explain make -j 4? E.g. "The -j 4 flag allows up to 4 processes to compile simulateously. Change 4 to the number of cores you can allot to compiling."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several adjustments and improvements to make as part of the JOSS review process; this branch will handle them in one place.