pyEXP bug fix #66
Merged
pyEXP bug fix #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 5, 2024 21:48
…le process pyEXP runs
…s/cols mnemonic in favor of an explicit choice of row major vs col major [no ci]
…vor of throwing std::runtime_error [no ci]
…ill still work but is now deprecated
added 18 commits
March 16, 2024 09:56
…the cuda config for DSMC for consistency [no ci]
…ion to reflect that [no ci]
…e this chatter in the long run but useful since the default changed [no ci]
|
After working with this for a couple weeks and having it be the de facto default through Docker, I can't see a reason not to merge this. |
|
Agreed, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be no API changes to any current workflows but this whole thing should be exercised and checked carefully.