Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Villager RNG Manipulation #642

Open
wants to merge 99 commits into
base: fabric
Choose a base branch
from

Conversation

RealRTTV
Copy link
Contributor

Add Villager RNG Manipulation to brute-force optimal trades

@xpple
Copy link
Collaborator

xpple commented May 31, 2024

Holy fuck nice!

@erxson
Copy link

erxson commented May 31, 2024

yooooo

RealRTTV and others added 24 commits May 31, 2024 14:55
- i need to fix for ping tho
- i can probably remove the clock requirement and use the day/night packets
- i can probably remove the clock requirement and use the day/night packets
Add simulation for more actions and add trade cracking for levels above 1
@Earthcomputer
Copy link
Owner

Earthcomputer commented Nov 30, 2024

can i test out build artifacts?
if so how?

Yeah you just unzip it, get the mod jar out of it and then install it like a regular mod. It's in a working state but I won't be providing support for using it. It needs to be made more user friendly before it can be merged.

@vanvac
Copy link

vanvac commented Nov 30, 2024

image
the only zip file i could find in the artifacts was for im guessing what are the unit tests (cheked the zip files and all there is are the html pages)

@Earthcomputer
Copy link
Owner

Ah sorry, I forgot artifacts are not built for PRs. You will have to clone the PR and build it yourself. But again, this channel is for development, it's best to join the discord and ask in support if you get stuck.

Copy link
Owner

@Earthcomputer Earthcomputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having some issues running it, see Discord

src/main/resources/assets/clientcommands/lang/en_us.json Outdated Show resolved Hide resolved
src/main/resources/assets/clientcommands/lang/en_us.json Outdated Show resolved Hide resolved
villager_rng_setup.png Outdated Show resolved Hide resolved
RealRTTV and others added 6 commits December 2, 2024 19:32
…king

# Conflicts:
#	src/main/java/net/earthcomputer/clientcommands/util/DebugRandom.java
…king

# Conflicts:
#	src/main/java/net/earthcomputer/clientcommands/features/FishingCracker.java
@vanvac
Copy link

vanvac commented Dec 21, 2024

any updates/problems or just waiting for soemthing to do with mc versions

@RealRTTV
Copy link
Contributor Author

RealRTTV commented Dec 22, 2024

currently we need to fix levelUp changes, but other than that it should be good

@vanvac
Copy link

vanvac commented Dec 22, 2024

hope this comes soon bc making villiager trading halls with this will be so much easier

@vanvac

This comment was marked as off-topic.

@vanvac
Copy link

vanvac commented Dec 25, 2024

Idk if this is a knows issue or not but if a viliager loses its profession while its running the rng manipulation after running /cvilliager start the villiager cracking just dies and prevents the command from being run again, it is fixed by reloging and prob many more

@RealRTTV
Copy link
Contributor Author

does /cvillager reset fix it?

@vanvac
Copy link

vanvac commented Jan 18, 2025

tried to recreat it and turns out my description isnt the best
also /cvilliager reset isn't an available command

reproduce problem:

  1. setup villiager cracking setup with a cracked villiager and a goal that would take a decent amount of time to find
  2. break the profession block when the bar at the bottom is flling and the cracking is doing its thing
  3. once the cracking completes it trys to open the villiager gui but cant as it is unemployed
  4. then giving the villiager a proffession and trying to crack it would fail

fixes:

  • relog
  • interact with the villiager and reset the proffesion so you can crack trades again

half fix: these things allow the villiager rng to be cracked again but do not fix the soft lock

  • anything that resets the villiager manipulation atumatically (eg. holding item in hand, villiager hurt, bad setup, etc)

ps. are there any plans to make it where you can specify like a below certian amount of emrald requirement eg. sharp 5 book for <=24 emralds

added `reset` subcommand
levelUp code is still broken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants