List advisory Location #630
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juberti
reviewed
Oct 3, 2023
| PyGithub | ||
| six # for some reason google cloud needs this |
There was a problem hiding this comment.
Shouldn't need this when using python3? Can you post the error you are seeing?
There was a problem hiding this comment.
This runs fine on my own local server, but errors for some reason in the test system on Github
static/js/index.js
Outdated
| @@ -460,13 +460,17 @@ function renderStudent(studentObj) { | |||
| var advisoryTag = '<p><iron-icon icon="icons:perm-identity"></iron-icon>' + | |||
| "Advisor: " + studentObj.advisor.charAt(1).toUpperCase() + | |||
| studentObj.advisor.slice(2) + "</p>"; | |||
| var advisoryLocationTag = '<p><iron-icon icon="icons:room"></iron-icon>' + | |||
| "Advisory Room: " + studentObj.classes[0][8].room + "</p>"; | |||
There was a problem hiding this comment.
This feels a bit fragile, and might not work well if the student has an unusual course load. Maybe add a function to get a class by name, and we can search for "Advisory"?
juberti
reviewed
Nov 9, 2023
| @@ -26,6 +26,14 @@ function renderGitHubCommits() { | |||
| }); | |||
| document.getElementById("GHUpdateText").innerHTML = updated; | |||
| } | |||
| function getCourseByName(studentClasses, name) { | |||
There was a problem hiding this comment.
The name parameter isn't being used here...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #629