[Search] Allow Searching in nested ORM\Embedded property #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmorel
commented
Oct 20, 2020
| $propertyMetadata = $associatedEntityDto->getPropertyMetadata($associatedPropertyName); | ||
| $targetEntity = $propertyMetadata->get('targetEntity'); | ||
| $associatedEntityDto = $this->entityFactory->create($targetEntity); | ||
| } catch (\InvalidArgumentException $exception) { |
gmorel
commented
Oct 20, 2020
| $targetEntity = $propertyMetadata->get('targetEntity'); | ||
| $associatedEntityDto = $this->entityFactory->create($targetEntity); | ||
| } catch (\InvalidArgumentException $exception) { | ||
| if ($this->isNestedEmbbededProperty($associatedProperties)) { |
gmorel
force-pushed
the
feature/allow_search_in_nested_embeddable
branch
from
52c698d to
648d9c4
Compare
gmorel
commented
Oct 20, 2020
| $targetEntity = $propertyMetadata->get('targetEntity'); | ||
| $associatedEntityDto = $this->entityFactory->create($targetEntity); | ||
| try { | ||
| $propertyMetadata = $associatedEntityDto->getPropertyMetadata($associatedPropertyName); |
|
I wanted to unit test it. But |
gmorel
changed the title
a.b.c where b is a ORM\Embedded
gmorel
force-pushed
the
feature/allow_search_in_nested_embeddable
branch
from
648d9c4 to
ed9ef98
Compare
Code was hard codded to fail if nested properties But was failing with Doctrine ORM\Embedded too
gmorel
commented
Oct 23, 2020
| @@ -21,7 +21,7 @@ public function supports(FieldDto $field, EntityDto $entityDto): bool | |||
| public function configure(FieldDto $field, EntityDto $entityDto, AdminContext $context): void | |||
| { | |||
| $isRenderedAsSwitch = true === $field->getCustomOption(BooleanField::OPTION_RENDER_AS_SWITCH); | |||
| if ($isRenderedAsSwitch && false !== strpos($field->getProperty(), '.')) { | |||
| if ($isRenderedAsSwitch && $this->isNestedProperty($field) && false === $this->isBoolean($field)) { | |||
There was a problem hiding this comment.
This was crashing the app during EDIT on boolean Doctrine Embedded properties
There was a problem hiding this comment.
Is this related to search? Seems like you are not fixing it but just ignoring it, or am I wrong?
I guess the AJAX request to change the value will not work with this change? Maybe remove this change and render the property as a normal boolean field, like the exception message says?
gmorel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pain Point
Thanks to #3864 you can now search on nested entities 🚀.
But if you try to search on an Entity which has nested Embedable you might have this error
CRUD config:
Usecase:
property(ORM\ManyToOne)landlord(ORM\ManyToOne)person1(ORM\Embedded)firstName(string)It fails to find
person1since onlyperson1.firstNameis mapped inlandlord.TODO