Fixes vanishing batch action bar when deselecting one item after selecting all elements #4353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cting all. Original code used a own input element to save which elements are selected. This input element was removed, so we can not determine the number of selected elements this way. The code now counts the checked checkboxes directly to determine the numbe of selected items.
gaelb80
reviewed
May 6, 2021
There was a problem hiding this comment.
@javiereguiluz just tested the PR it works great. Just need a review to remove useless code
| @@ -309,21 +309,17 @@ | |||
| $(document).on('change', '.form-batch-checkbox', function () { | |||
| const $content = $(this).closest('.content'); | |||
| let $input = $content.find(':hidden#batch_form_entityIds'); | |||
| let ids = $input.val() ? $input.val().split(',') : []; | |||
| const numberOfSelectedItems = $('input[type="checkbox"].form-batch-checkbox:checked').length; | |||
| const id = $(this).val(); | |||
…cting all. Original code used a own input element to save which elements are selected. This input element was removed, so we can not determine the number of selected elements this way. The code now counts the checked checkboxes directly to determine the numbe of selected items.
… fix_batch_action_selection
…_action_selection" This reverts commit 4f7a3f9.
|
Is this still valid? I don't see this problem with latest EasyAdmin 4.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all items were selected, and one element is unselected, the bar with the batch actions disappear, which makes it very difficult to select all but one element.
The original code by @versh23 used a own input element to save which elements are selected. This input element was removed, so we can not determine the number of selected elements this way. The code now counts the checked checkboxes directly to determine the numbe of selected items.
With this pull request the behavior is now correct.